From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756753AbdKDNZo (ORCPT ); Sat, 4 Nov 2017 09:25:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35088 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752103AbdKDNZn (ORCPT ); Sat, 4 Nov 2017 09:25:43 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A5ED25F7BA Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Sat, 4 Nov 2017 14:25:32 +0100 From: Jiri Olsa To: Megha Dey Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, andriy.shevchenko@linux.intel.com, kstewart@linuxfoundation.org, yu-cheng.yu@intel.com, len.brown@intel.com, gregkh@linuxfoundation.org, peterz@infradead.org, acme@kernel.org, alexander.shishkin@linux.intel.com, namhyung@kernel.org, vikas.shivappa@linux.intel.com, pombredanne@nexb.com, me@kylehuey.com, bp@suse.de, grzegorz.andrejczuk@intel.com, tony.luck@intel.com, corbet@lwn.net, ravi.v.shankar@intel.com, megha.dey@intel.com Subject: Re: [PATCH V0 2/3] perf/x86/intel/bm.c: Add Intel Branch Monitoring support Message-ID: <20171104132532.GC8454@krava> References: <1509732006-5917-1-git-send-email-megha.dey@linux.intel.com> <1509732006-5917-3-git-send-email-megha.dey@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509732006-5917-3-git-send-email-megha.dey@linux.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Sat, 04 Nov 2017 13:25:42 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 03, 2017 at 11:00:05AM -0700, Megha Dey wrote: SNIP > + event->hw.bm_ctrl = (bm_window_size << BM_WINDOW_SIZE_SHIFT) | > + (bm_guest_disable << BM_GUEST_DISABLE_SHIFT) | > + (bm_lbr_freeze << BM_LBR_FREEZE_SHIFT) | > + (bm_window_cnt_sel << BM_WINDOW_CNT_SEL_SHIFT) | > + (bm_cnt_and_mode << BM_CNT_AND_MODE_SHIFT) | > + BM_ENABLE; > + event->hw.bm_counter_conf = (bm_threshold << BM_THRESHOLD_SHIFT) | > + (bm_mispred_evt_cnt << BM_MISPRED_EVT_CNT_SHIFT) | > + (cfg << BM_EVENT_TYPE_SHIFT); > + > + wrmsrl(BR_DETECT_COUNTER_CONFIG_BASE + counter_to_use, > + event->hw.bm_counter_conf); > + wrmsrl(BR_DETECT_STATUS_MSR, 0); > + event->id = counter_to_use; I think you need to add your own id under hw_perf_event::intel_bm we use event->id as event unique id expected also in perf stat for group reading or stat record thanks, jirka