From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752561AbdKECgt (ORCPT ); Sat, 4 Nov 2017 22:36:49 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:45338 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751508AbdKECgr (ORCPT ); Sat, 4 Nov 2017 22:36:47 -0400 X-Google-Smtp-Source: ABhQp+Qwk+m8vkRSP1RXEfpBMrT5JW7FueKpSIaMGQVG2rbi1CjH3PZ4TLd5L/6Qs1dfawCOeIJxcQ== Date: Sat, 4 Nov 2017 19:36:43 -0700 From: Kees Cook To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org Subject: [PATCH] drivers/pcmcia: omap1: Fix error in automated timer conversion Message-ID: <20171105023643.GA130117@beast> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org One part of automated timer conversion tools did not take into account void * variables when searching out prior direct timer callback usage, which resulted in an attempt to dereference the timer field without a proper type. Reported-by: kbuild test robot Signed-off-by: Kees Cook --- drivers/pcmcia/omap_cf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pcmcia/omap_cf.c b/drivers/pcmcia/omap_cf.c index 8216ceb51b18..c2a17a79f0b2 100644 --- a/drivers/pcmcia/omap_cf.c +++ b/drivers/pcmcia/omap_cf.c @@ -102,7 +102,9 @@ static void omap_cf_timer(struct timer_list *t) */ static irqreturn_t omap_cf_irq(int irq, void *_cf) { - omap_cf_timer(&_cf->timer); + struct omap_cf_socket *cf = (struct omap_cf_socket *)_cf; + + omap_cf_timer(&cf->timer); return IRQ_HANDLED; } -- 2.7.4 -- Kees Cook Pixel Security