From: Johan Hovold <johan@kernel.org>
To: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
Cc: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, keescook@chromium.org,
linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org
Subject: Re: [PATCH 1/2] staging: greybus: operation: add private data with get/set accessors
Date: Sun, 5 Nov 2017 13:19:02 +0100 [thread overview]
Message-ID: <20171105121902.GA10137@localhost> (raw)
In-Reply-To: <1509852459-5847-2-git-send-email-pure.logic@nexus-software.ie>
On Sun, Nov 05, 2017 at 03:27:38AM +0000, Bryan O'Donoghue wrote:
> Asynchronous operation completion handler's lives are made easier if there
> is a generic pointer that can store private data associated with the
> operation. This patch adds a pointer field to operation.h and get/set
As I mentioned in my review of v3 (back in January), this should be
s/operation.h/struct gb_operation/.
> methods to access that pointer.
>
> Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Reviewed-by: Johan Hovold <johan@kernel.org>
> --- a/drivers/staging/greybus/operation.h
> +++ b/drivers/staging/greybus/operation.h
> @@ -105,6 +105,8 @@ struct gb_operation {
>
> int active;
> struct list_head links; /* connection->operations */
> +
> + void *private;
> };
Johan
next prev parent reply other threads:[~2017-11-05 12:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-05 3:27 [PATCH 0/2] Convert greybus loopback to core async API Bryan O'Donoghue
2017-11-05 3:27 ` [PATCH 1/2] staging: greybus: operation: add private data with get/set accessors Bryan O'Donoghue
2017-11-05 12:19 ` Johan Hovold [this message]
2017-11-05 3:27 ` [PATCH 2/2] staging: greybus: loopback: convert loopback to use generic async operations Bryan O'Donoghue
2017-11-05 12:24 ` Johan Hovold
2017-11-06 0:05 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171105121902.GA10137@localhost \
--to=johan@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pure.logic@nexus-software.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox