From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752346AbdKEMTG (ORCPT <rfc822;w@1wt.eu>);
        Sun, 5 Nov 2017 07:19:06 -0500
Received: from mail-lf0-f67.google.com ([209.85.215.67]:45262 "EHLO
        mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751095AbdKEMTE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 5 Nov 2017 07:19:04 -0500
X-Google-Smtp-Source: ABhQp+QgD9Ny7zaFIkuAXPGNABPwp6kXIOf9tIBWUAlbDscuqW9c1QtBSpc98rGG7dEyW2hoUjmqWA==
Date: Sun, 5 Nov 2017 13:19:02 +0100
From: Johan Hovold <johan@kernel.org>
To: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
Cc: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org,
        devel@driverdev.osuosl.org, keescook@chromium.org,
        linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org
Subject: Re: [PATCH 1/2] staging: greybus: operation: add private data with
 get/set accessors
Message-ID: <20171105121902.GA10137@localhost>
References: <1509852459-5847-1-git-send-email-pure.logic@nexus-software.ie>
 <1509852459-5847-2-git-send-email-pure.logic@nexus-software.ie>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1509852459-5847-2-git-send-email-pure.logic@nexus-software.ie>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Nov 05, 2017 at 03:27:38AM +0000, Bryan O'Donoghue wrote:
> Asynchronous operation completion handler's lives are made easier if there
> is a generic pointer that can store private data associated with the
> operation. This patch adds a pointer field to operation.h and get/set

As I mentioned in my review of v3 (back in January), this should be
s/operation.h/struct gb_operation/.

> methods to access that pointer.
> 
> Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>

Reviewed-by: Johan Hovold <johan@kernel.org>

> --- a/drivers/staging/greybus/operation.h
> +++ b/drivers/staging/greybus/operation.h
> @@ -105,6 +105,8 @@ struct gb_operation {
>  
>  	int			active;
>  	struct list_head	links;		/* connection->operations */
> +
> +	void			*private;
>  };

Johan