From: Prarit Bhargava <prarit@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Prarit Bhargava <prarit@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Peter Zijlstra <peterz@infradead.org>,
Andi Kleen <ak@linux.intel.com>,
Dave Hansen <dave.hansen@intel.com>,
Piotr Luc <piotr.luc@intel.com>, Kan Liang <kan.liang@intel.com>,
Borislav Petkov <bp@suse.de>,
Stephane Eranian <eranian@google.com>,
Arvind Yadav <arvind.yadav.cs@gmail.com>,
Andy Lutomirski <luto@kernel.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Mathias Krause <minipli@googlemail.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>
Subject: [PATCH v5 0/3] Fix panic in logical packages calculation
Date: Sun, 5 Nov 2017 11:54:25 -0500 [thread overview]
Message-ID: <20171105165428.32108-1-prarit@redhat.com> (raw)
A system booted with a small number of cores enabled per package
panics because the estimate of __max_logical_packages is too low.
This occurs when the total number of active cores across all packages
is less than the maximum core count for a single package.
Andi noted that the logical_packages calculation wastes 128k on 64-bit
x86 systems and posted patches to fix the allocation. His patches
result in significant memory size savings, and I have put my
fix on top of those patches.
Here's an example of the panic:
smpboot: Booting Node 1, Processors #1 OK
smpboot: Package 1 of CPU 1 exceeds BIOS package data 1.
------------[ cut here ]------------
kernel BUG at arch/x86/kernel/cpu/common.c:1087!
invalid opcode: 0000 [#1] SMP
Modules linked in:
CPU: 1 PID: 0 Comm: swapper/1 Not tainted 4.14.0-rc2+ #4
This was tested by dropping the number of active cores across
all packages to reproduce the bug above. Additional testing included
2 socket and 4 socket systems and hotplugging entire sockets in different
order.
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: Piotr Luc <piotr.luc@intel.com>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Stephane Eranian <eranian@google.com>
Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Mathias Krause <minipli@googlemail.com>
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
Andi Kleen (2):
perf/x86/intel/uncore: Cache logical pkg id in uncore driver
x86/topology: Avoid wasting 128k for package id array
Prarit Bhargava (1):
x86/smpboot: Fix __max_logical_packages estimate
arch/x86/events/intel/uncore.c | 1 +
arch/x86/events/intel/uncore.h | 1 +
arch/x86/events/intel/uncore_snbep.c | 2 +-
arch/x86/kernel/smpboot.c | 148 ++++++++++++++---------------------
4 files changed, 61 insertions(+), 91 deletions(-)
--
2.15.0.rc0.39.g2f0e14e64
next reply other threads:[~2017-11-05 16:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-05 16:54 Prarit Bhargava [this message]
2017-11-05 16:54 ` [PATCH v5 1/3] perf/x86/intel/uncore: Cache logical pkg id in uncore driver Prarit Bhargava
2017-11-07 22:19 ` Thomas Gleixner
2017-11-05 16:54 ` [PATCH v5 2/3] x86/topology: Avoid wasting 128k for package id array Prarit Bhargava
2017-11-10 0:43 ` Thomas Gleixner
2017-11-10 12:29 ` Prarit Bhargava
2017-11-10 12:52 ` Thomas Gleixner
2017-11-10 12:56 ` Thomas Gleixner
2017-11-10 15:01 ` Andi Kleen
2017-11-10 18:35 ` Prarit Bhargava
2017-11-10 19:39 ` Andi Kleen
2017-11-12 13:36 ` Thomas Gleixner
2017-11-12 16:55 ` Prarit Bhargava
2017-11-10 2:42 ` [lkp-robot] [x86/topology] 4b5ebf8be9: BUG:KASAN:slab-out-of-bounds kernel test robot
2017-11-05 16:54 ` [PATCH v5 3/3] x86/smpboot: Fix __max_logical_packages estimate Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171105165428.32108-1-prarit@redhat.com \
--to=prarit@redhat.com \
--cc=ak@linux.intel.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=bp@suse.de \
--cc=dave.hansen@intel.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=kan.liang@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=minipli@googlemail.com \
--cc=peterz@infradead.org \
--cc=piotr.luc@intel.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tim.c.chen@linux.intel.com \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox