From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751321AbdKFDGB (ORCPT ); Sun, 5 Nov 2017 22:06:01 -0500 Received: from mga05.intel.com ([192.55.52.43]:47558 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750888AbdKFDGA (ORCPT ); Sun, 5 Nov 2017 22:06:00 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,350,1505804400"; d="asc'?scan'208";a="1214605161" Date: Mon, 6 Nov 2017 10:58:50 +0800 From: "Du, Changbin" To: Ingo Molnar Cc: changbin.du@intel.com, hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com Subject: Re: [PATCH 1/4] x86, build: Fact out fdimage/isoimage generation commands to standalone script Message-ID: <20171106025849.GA1464@intel.com> References: <1509873493-17929-1-git-send-email-changbin.du@intel.com> <1509873493-17929-2-git-send-email-changbin.du@intel.com> <20171105093208.5ncgz4o4klv3f3xn@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+HP7ph2BbKc20aGI" Content-Disposition: inline In-Reply-To: <20171105093208.5ncgz4o4klv3f3xn@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --+HP7ph2BbKc20aGI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 05, 2017 at 10:32:08AM +0100, Ingo Molnar wrote: >=20 > A few spelling fixes: >=20 > in the title: >=20 > s/Fact out > /Factor out >=20 > * changbin.du@intel.com wrote: >=20 > > From: Changbin Du > >=20 > > The build message for fdimage/isoimage are pretty unstructured. The raw > > shell command blocks are printed. We can improve them as regular build > > system messages. Besides, writing commands in shell script is much more > > easier than in a Makefile. >=20 > s/much more easier > /much more easy >=20 > >=20 > > See Ingo's suggestion here https://lkml.org/lkml/2017/10/31/124. > >=20 > > This patch fact out the commands used for fdimage/isoimage generation f= rom > > arch/x86/boot/Makefile to new script arch/x86/boot/genimage.sh. Then ad= d a > > new kbuild command 'genimage' which invokes the new script. All > > fdimages/isoimage now is generated by call to 'genimage' with different > > parameters. >=20 > s/fact out > /factors out >=20 > s/to new script > to a new script >=20 > s/Then add > /Then it adds >=20 > s/a new kbuild command 'genimage' > /the new 'genimage' kbuild command >=20 > s/All fdimages/isoimage now is generated by call to > /All fdimage/isoimage files are now generated by a call to >=20 Sorry for these grammar errors. I alwyas forgot to write complete sentences= in English. :) > > +# $3 - kernel bzImage file > > +# $4 - mtool configuration file > > +# $5 - kernel cmdline > > +# $6 - inird image file > > +# >=20 > The new script is much easier to read! >=20 > Thanks, >=20 > Ingo --=20 Thanks, Changbin Du --+HP7ph2BbKc20aGI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJZ/8/pAAoJEAanuZwLnPNUguMIAI9jfv6qGABWwov1Yjeyx0TJ r7IoRS1bts/hMtM/O17+Nyh/zme6LHVxHvkI0uSgJ3qj1qI6Uxh57nE3YR4fLvTx fkEAb1TRFL5+8lFK6uLJ3mdCKoG7K2a1INAZgcjwzI6I8/MmiW/osBKxMd0RGiv5 AS4f9WdfhPWH93bYE0Ul9Gr08nFvuhxPJFoYIW6iqhfsVwlaBN5DCIVPOZZlWULU zWmF0+ae0Zk6o2aQEZswlSVG335nTg59hqTZqOMeNerWOsdgJ7G68sjZQVmkUba7 GJLDnKslnf22VTHeQiTOqWGVPJK8cTKLDHGeqGTC9/MTO8xD3CCEI+qe/+PSszg= =Wp2j -----END PGP SIGNATURE----- --+HP7ph2BbKc20aGI--