Re: [PATCH 2/4] x86, build: Add new paths for isolinux.bin and ldlinux.c32

["Du, Changbin" <changbin.du@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]

Hi Ingo,
On Sun, Nov 05, 2017 at 10:33:53AM +0100, Ingo Molnar wrote:
> 
> * changbin.du@intel.com <changbin.du@intel.com> wrote:
> 
> > From: Changbin Du <changbin.du@intel.com>
> > 
> > Recently I failed to build isoimage target, because the path of isolinux.bin
> > changed to /usr/xxx/ISOLINUX/isolinux.bin, as well as ldlinux.c32 which
> > changed to /usr/xxx/syslinux/modules/bios/ldlinux.c32.
> > 
> > This patch has a improvement of the file search:
> >   - Show a error message instead of silent fail.
> >   - Add above new paths.
> 
> How about:
> 
>   This patch improves the file search logic:
>     - Show an error message instead of failing silently
>     - Add the new paths listed above.
> 
> 
> > +		if [ $i = end -a -z "$isolinux" ] ; then
> > +			echo 'Need isolinux.bin, please install syslinux/isolinux'
> 
> How about:
> 
> 			echo 'Need an isolinux.bin file, please install syslinux/isolinux'
>
The new description is much better, will update. Thanks.

> Thanks,
> 
> 	Ingo

-- 
Thanks,
Changbin Du

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]