From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752875AbdKFJRy (ORCPT ); Mon, 6 Nov 2017 04:17:54 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:46076 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751490AbdKFJRs (ORCPT ); Mon, 6 Nov 2017 04:17:48 -0500 X-Google-Smtp-Source: ABhQp+QdneBVk0Io7TnyVbVivK0oZNAhnujDpuIfzjpqnQ3ooJgUruVsvYCI6AtaN78qAfYuvqZKGQ== Date: Mon, 6 Nov 2017 10:17:46 +0100 From: Johan Hovold To: "Bryan O'Donoghue" Cc: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, keescook@chromium.org, linux-kernel@vger.kernel.org, Mitch Tasman , greybus-dev@lists.linaro.org Subject: Re: [PATCH v3 1/4] staging: greybus: loopback: Hold per-connection mutex across operations Message-ID: <20171106091746.GB11226@localhost> References: <1509931942-25712-1-git-send-email-pure.logic@nexus-software.ie> <1509931942-25712-2-git-send-email-pure.logic@nexus-software.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509931942-25712-2-git-send-email-pure.logic@nexus-software.ie> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 06, 2017 at 01:32:19AM +0000, Bryan O'Donoghue wrote: > Commit d9fb3754ecf8 ("greybus: loopback: Relax locking during loopback > operations") changes the holding of the per-connection mutex to be less > restrictive because at the time of that commit per-connection mutexes were > encapsulated by a per-driver level gb_dev.mutex. > > Commit 8e1d6c336d74 ("greybus: loopback: drop bus aggregate calculation") > on the other hand subtracts the driver level gb_dev.mutex but neglects to > move the mutex back to the place it was prior to commit d9fb3754ecf8 > ("greybus: loopback: Relax locking during loopback operations"), as a > result several members of the per connection struct gb_loopback are racy. > > The solution is restoring the old location of mutex_unlock(&gb->mutex) as > it was in commit d9fb3754ecf8 ("greybus: loopback: Relax locking during > loopback operations"). > > Fixes: 8e1d6c336d74 ("greybus: loopback: drop bus aggregate calculation") > > Signed-off-by: Bryan O'Donoghue > Cc: Johan Hovold > Cc: Alex Elder > Cc: Greg Kroah-Hartman > Cc: Mitch Tasman > Cc: greybus-dev@lists.linaro.org > Cc: devel@driverdev.osuosl.org > Cc: linux-kernel@vger.kernel.org > --- This looks like it addresses both my comments on v1 (mutex and error stats). Thanks for tracking it down. Reviewed-by: Johan Hovold Johan