From: Johan Hovold <johan@kernel.org>
To: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
Cc: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, keescook@chromium.org,
linux-kernel@vger.kernel.org, Mitch Tasman <tasman@leaflabs.com>,
greybus-dev@lists.linaro.org
Subject: Re: [PATCH v3 4/4] staging: greybus: loopback: convert loopback to use generic async operations
Date: Mon, 6 Nov 2017 10:19:12 +0100 [thread overview]
Message-ID: <20171106091912.GD11226@localhost> (raw)
In-Reply-To: <1509931942-25712-5-git-send-email-pure.logic@nexus-software.ie>
On Mon, Nov 06, 2017 at 01:32:22AM +0000, Bryan O'Donoghue wrote:
> Loopback has its own internal method for tracking and timing out
> asynchronous operations however previous patches make it possible to use
> functionality provided by operation.c to do this instead. Using the code in
> operation.c means we can completely subtract the timer, the work-queue, the
> kref and the cringe-worthy 'pending' flag. The completion callback
> triggered by operation.c will provide an authoritative result code -
> including -ETIMEDOUT for asynchronous operations.
>
> Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Reviewed-by: Johan Hovold <johan@kernel.org>
prev parent reply other threads:[~2017-11-06 9:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 1:32 [PATCH v3 0/4] Convert greybus loopback to core async API Bryan O'Donoghue
2017-11-06 1:32 ` [PATCH v3 1/4] staging: greybus: loopback: Hold per-connection mutex across operations Bryan O'Donoghue
2017-11-06 9:17 ` Johan Hovold
2017-11-06 1:32 ` [PATCH v3 2/4] staging: greybus: loopback: Fix iteration count on async path Bryan O'Donoghue
2017-11-06 9:18 ` Johan Hovold
2017-11-06 1:32 ` [PATCH v3 3/4] staging: greybus: operation: add private data with get/set accessors Bryan O'Donoghue
2017-11-06 1:32 ` [PATCH v3 4/4] staging: greybus: loopback: convert loopback to use generic async operations Bryan O'Donoghue
2017-11-06 9:19 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106091912.GD11226@localhost \
--to=johan@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pure.logic@nexus-software.ie \
--cc=tasman@leaflabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox