From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752809AbdKFJTf (ORCPT ); Mon, 6 Nov 2017 04:19:35 -0500 Received: from mail-lf0-f51.google.com ([209.85.215.51]:50969 "EHLO mail-lf0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbdKFJTN (ORCPT ); Mon, 6 Nov 2017 04:19:13 -0500 X-Google-Smtp-Source: ABhQp+SL0bgR06EVhFRxKxZV4H+XasEjSLjw/FgkySieBrZiC+yxfsw+y43OcWlEN8p1vDo2BAYNtQ== Date: Mon, 6 Nov 2017 10:19:12 +0100 From: Johan Hovold To: "Bryan O'Donoghue" Cc: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, keescook@chromium.org, linux-kernel@vger.kernel.org, Mitch Tasman , greybus-dev@lists.linaro.org Subject: Re: [PATCH v3 4/4] staging: greybus: loopback: convert loopback to use generic async operations Message-ID: <20171106091912.GD11226@localhost> References: <1509931942-25712-1-git-send-email-pure.logic@nexus-software.ie> <1509931942-25712-5-git-send-email-pure.logic@nexus-software.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509931942-25712-5-git-send-email-pure.logic@nexus-software.ie> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 06, 2017 at 01:32:22AM +0000, Bryan O'Donoghue wrote: > Loopback has its own internal method for tracking and timing out > asynchronous operations however previous patches make it possible to use > functionality provided by operation.c to do this instead. Using the code in > operation.c means we can completely subtract the timer, the work-queue, the > kref and the cringe-worthy 'pending' flag. The completion callback > triggered by operation.c will provide an authoritative result code - > including -ETIMEDOUT for asynchronous operations. > > Signed-off-by: Bryan O'Donoghue Reviewed-by: Johan Hovold