Re: [PATCH v3 1/2] livepatch: send a fake signal to all blocking tasks

Josh Poimboeuf
2017-11-03T12:57:19Z

On Fri, Nov 03, 2017 at 09:02:50AM +0100, Miroslav Benes wrote:
> On Thu, 2 Nov 2017, Josh Poimboeuf wrote:
>
> > On Tue, Oct 31, 2017 at 12:48:52PM +0100, Miroslav Benes wrote:
> > > +
> > > +/*
> > > + * Sends a fake signal to all non-kthread tasks with TIF_PATCH_PENDING set.
> > > + * Kthreads with TIF_PATCH_PENDING set are woken up. Only admin can request this
> > > + * action currently.
> > > + */
> > > +void klp_force_signals(void)
> >
> > Since "force" now has a separate meaning, it's a little confusing to
> > have it in the name of this function. How about klp_send_signals() or
> > klp_signal()?
>
> or klp_send_signal()?

It can send more than one signal, so I'd prefer the plural form:
klp_send_signals().

--
Josh