From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753546AbdKFPQZ (ORCPT ); Mon, 6 Nov 2017 10:16:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43536 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751976AbdKFPQX (ORCPT ); Mon, 6 Nov 2017 10:16:23 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5E91B7CBAC Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jbenc@redhat.com Date: Mon, 6 Nov 2017 16:16:20 +0100 From: Jiri Benc To: Colin King Cc: "David S . Miller" , David Ahern , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtnetlink: fix missing size for IFLA_IF_NETNSID Message-ID: <20171106161620.7080cf66@redhat.com> In-Reply-To: <20171106150454.9623-1-colin.king@canonical.com> References: <20171106150454.9623-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 06 Nov 2017 15:16:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Nov 2017 15:04:54 +0000, Colin King wrote: > The size for IFLA_IF_NETNSID is missing from the size calculation > because the proceeding semicolon was not removed. Fix this by removing > the semicolon. Acked-by: Jiri Benc Thanks for spotting this! Looking at my initial code, I had that right, this was probably introduced during one of rebases, so I blame Flavio :-p (On a serious note, thank you, Flavio, for taking care of the rebases.) Hopefully, with the "+ 0" added, this won't happen again in this particular piece of code in the future. Jiri