From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754457AbdKFQ5E (ORCPT ); Mon, 6 Nov 2017 11:57:04 -0500 Received: from mga14.intel.com ([192.55.52.115]:43751 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754434AbdKFQ5D (ORCPT ); Mon, 6 Nov 2017 11:57:03 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,353,1505804400"; d="scan'208";a="146541447" Date: Tue, 7 Nov 2017 00:56:48 +0800 From: "Liu, Changcheng" To: Josh Poimboeuf , Petr Mladek , Sergey Senozhatsky , changcheng.liu@intel.com Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] lib_backtrace: fix kernel text address leak Message-ID: <20171106165648.GA95243@sofia> References: <20171106052511.GB69364@sofia> <20171106080528.GA1298@jagdpanzerIV> <20171106105203.GC69364@sofia> <20171106131147.ouihd4ug5ah3vb6a@treble> <20171106164847.GD69364@sofia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171106164847.GD69364@sofia> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Don't leak idle function address in NMI backtrace. Signed-off-by: Liu Changcheng diff --git a/lib/nmi_backtrace.c b/lib/nmi_backtrace.c index 46e4c749..61a6b5a 100644 --- a/lib/nmi_backtrace.c +++ b/lib/nmi_backtrace.c @@ -93,8 +93,8 @@ bool nmi_cpu_backtrace(struct pt_regs *regs) if (cpumask_test_cpu(cpu, to_cpumask(backtrace_mask))) { arch_spin_lock(&lock); if (regs && cpu_in_idle(instruction_pointer(regs))) { - pr_warn("NMI backtrace for cpu %d skipped: idling at pc %#lx\n", - cpu, instruction_pointer(regs)); + pr_warn("NMI backtrace for cpu %d skipped: idling at %pS\n", + cpu, (void *)instruction_pointer(regs)); } else { pr_warn("NMI backtrace for cpu %d\n", cpu); if (regs) -- 2.7.4