From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752224AbdKGEkz (ORCPT ); Mon, 6 Nov 2017 23:40:55 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:53191 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752134AbdKGEky (ORCPT ); Mon, 6 Nov 2017 23:40:54 -0500 X-Google-Smtp-Source: ABhQp+QhtygxXKoohvdAwLute3sdko4lqmq0iZfW1yEmZYSIL2rI92II4O4GGwEnXqmKVGSTVMphgQ== Date: Tue, 7 Nov 2017 13:40:49 +0900 From: Sergey Senozhatsky To: Tejun Heo Cc: Petr Mladek , Sergey Senozhatsky , Steven Rostedt , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 1/2] printk: Relocate wake_klogd check close to the end of console_unlock() Message-ID: <20171107044049.GG1822@jagdpanzerIV> References: <20171102135146.GN3252168@devbig577.frc2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171102135146.GN3252168@devbig577.frc2.facebook.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (11/02/17 06:51), Tejun Heo wrote: > We mark for waking up klogd whenever we see a new message sequence in > the main loop. However, the actual wakeup is always at the end of the > function and we can easily test for the wakeup condition when we do > the final should-we-repeat check. > > Move the wake_klogd condition check out of the main loop. This avoids > doing the same thing repeatedly and groups similar checks into a > common place. > > Signed-off-by: Tejun Heo > Cc: Petr Mladek > Cc: Sergey Senozhatsky > Cc: Steven Rostedt looks good to me. FWIW, Reviewed-by: Sergey Senozhatsky -ss