From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757236AbdKGKmn (ORCPT ); Tue, 7 Nov 2017 05:42:43 -0500 Received: from mga04.intel.com ([192.55.52.120]:42427 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751565AbdKGKmj (ORCPT ); Tue, 7 Nov 2017 05:42:39 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,358,1505804400"; d="asc'?scan'208";a="146836762" Date: Tue, 7 Nov 2017 18:35:24 +0800 From: "Du, Changbin" To: Ingo Molnar Cc: changbin.du@intel.com, hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com Subject: Re: [PATCH v2 1/4] x86, build: Factor out fdimage/isoimage generation commands to standalone script Message-ID: <20171107103524.GA16764@intel.com> References: <1509939179-7556-1-git-send-email-changbin.du@intel.com> <1509939179-7556-2-git-send-email-changbin.du@intel.com> <20171107102029.4zvhovgdguthyg6u@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="T4sUOijqQbZv57TR" Content-Disposition: inline In-Reply-To: <20171107102029.4zvhovgdguthyg6u@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --T4sUOijqQbZv57TR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 07, 2017 at 11:20:29AM +0100, Ingo Molnar wrote: >=20 > * changbin.du@intel.com wrote: >=20 > > From: Changbin Du > >=20 > > The build message for fdimage/isoimage are pretty unstructured. The raw > > shell command blocks are printed. We can improve them as regular build > > system messages. Besides, writing commands in a shell script is much mo= re > > easy than in a Makefile. > >=20 > > See Ingo's suggestion here https://lkml.org/lkml/2017/10/31/124. > >=20 > > This patch factors out the commands used for fdimage/isoimage generation > > from arch/x86/boot/Makefile to a new script arch/x86/boot/genimage.sh. > > Then it adds the new kbuild command 'genimage' which invokes the new sc= ript. > > All fdimages/isoimage files are now generated by a call to 'genimage' w= ith > > different parameters. > >=20 > > Now 'make isoimage' becomes: > > ... > > Kernel: arch/x86/boot/bzImage is ready (#30) > > GENIMAGE arch/x86/boot/image.iso > > Size of boot image is 4 sectors -> No emulation > > 15.37% done, estimate finish Sun Nov 5 23:36:57 2017 > > 30.68% done, estimate finish Sun Nov 5 23:36:57 2017 > > 46.04% done, estimate finish Sun Nov 5 23:36:57 2017 > > 61.35% done, estimate finish Sun Nov 5 23:36:57 2017 > > 76.69% done, estimate finish Sun Nov 5 23:36:57 2017 > > 92.00% done, estimate finish Sun Nov 5 23:36:57 2017 > > Total translation table size: 2048 > > Total rockridge attributes bytes: 659 > > Total directory bytes: 0 > > Path table size(bytes): 10 > > Max brk space used 0 > > 32608 extents written (63 MB) > > Kernel: arch/x86/boot/image.iso is ready >=20 > Could we please also do another patch, to make it emit only this by defau= lt: >=20 > > GENIMAGE arch/x86/boot/image.iso >=20 > None of the other messages really matter to the user. >=20 > Maybe emit them when building with V=3D1 - but none of that info is reall= y=20 > interesting IMHO. >=20 Ingo, do you mean that omit below messages? Size of boot image is 4 sectors -> No emulation 15.37% done, estimate finish Sun Nov 5 23:36:57 2017 =2E.. 32608 extents written (63 MB) These are printed by mkisofs. How about just add '-quite' parameter to it? Kernel: arch/x86/boot/bzImage is ready (#75) GENIMAGE arch/x86/boot/image.iso Using /usr/lib/ISOLINUX/isolinux.bin Using /usr/lib/syslinux/modules/bios/ldlinux.c32 Kernel: arch/x86/boot/image.iso is ready > Thanks, >=20 > Ingo --=20 Thanks, Changbin Du --T4sUOijqQbZv57TR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJaAYxsAAoJEAanuZwLnPNUgosH/0/7wTc76213eyVOIeJGT+cu Axmuu90R0It/Kbp7l8/aaGfjIoKdGn5CzBumCvcv/hhnkFOTeSVDnsbvYwae04jt tMCh2ZID00I5juT61TZVCIgtbGWODPj96YcYUtgU0OmY7DujIOeqh+hbZ3MP8ffQ a6ZKX5JDk3O1eLeoQXUykTko3Xbn3HBUdhjtgKH891vu6lJ8kA+pV5+xcZgYeOEQ 199NYjX1qg62qpge7wcuXPB4MHL6QNPZn2dMzxTL0xcf7jS6XLo8/MK2Ln2IqVim 2tX74yzht/RP4uefsz5J6DZW91J3Mb/ZSD8+Tf1F81HdkJmZ9Qj7Cp1E0fd/lzY= =a3oU -----END PGP SIGNATURE----- --T4sUOijqQbZv57TR--