From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755013AbdKGMuK (ORCPT ); Tue, 7 Nov 2017 07:50:10 -0500 Received: from mail-sn1nam02on0080.outbound.protection.outlook.com ([104.47.36.80]:52960 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752850AbdKGMuF (ORCPT ); Tue, 7 Nov 2017 07:50:05 -0500 Authentication-Results: spf=none (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=permerror action=none header.from=amd.com; Date: Tue, 7 Nov 2017 20:50:53 +0800 From: Huang Rui To: Mark Rutland CC: Subject: Re: perf/x86/amd/power missing pmu::module initialisation Message-ID: <20171107125046.GA10337@hr-amur2> References: <20171103113355.trx34ebuyhw7bej4@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20171103113355.trx34ebuyhw7bej4@lakrids.cambridge.arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:165.204.84.17;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(376002)(39860400002)(346002)(2980300002)(428002)(3190300001)(189002)(199003)(24454002)(2906002)(58126008)(478600001)(316002)(16586007)(77096006)(229853002)(50466002)(189998001)(86362001)(97736004)(68736007)(9686003)(55016002)(2950100002)(6916009)(6246003)(81166006)(1076002)(8936002)(81156014)(83506002)(46406003)(5660300001)(8676002)(4326008)(101416001)(23726003)(6666003)(53936002)(97756001)(72206003)(33656002)(106466001)(47776003)(33716001)(105586002)(305945005)(50986999)(76176999)(54356999)(356003)(18370500001)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR1201MB0054;H:SATLEXCHOV01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2NAM03FT015;1:ejKMyLWawvX1F9oJ0To8tCnX7cvZL6lS1NLt1k5fSykSx1zPiJe7X0O3BlEjSN8avamzgPwG+1HfuGet6JA3QgnUcpe1AXaLnuiRyX4enALKMQQ7/516Jlyc5Z7VvXEi X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3c711d82-4a1a-4556-329f-08d525de10d0 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:CY4PR1201MB0054; X-Microsoft-Exchange-Diagnostics: 1;CY4PR1201MB0054;3:ofGQECV+Jlcjl6OF993UUch1StXqABI77AdjZ5rN6Unh8t/JWbWSc4zaZ/m4w1hcnFkaUQ7qItEqIy7eSw/VtohjSf1NMICAtZiFrxepy0+iQvfdV8lWPMI5GGhjSJCP03R3NbNRGihiEvyDfCcsfVkAfhz/dXFWN5nAyf35G3EvSSl75wduztDoZybe+iN43I54uMfnmpRE1c8KKMx4qmaZXOTpfYDadtV+2dROra6CJRPYM7hKQSJaFMLyWVisq5dcdI6WZyXFng2c3JXzTUbdXTTfkHwIADjvG3bkBOSt64rzagtIk1A0ctMrKrtIy41N+0vfSz+OKXrMxPNgmmId4oxPZbJR//dSntQjUqw=;25:HHTUFQO40qMXuI4kofTmpDfOsJBEDSUhm34+vrCFRkryrtZ07xEpzeN8sYR74Qj2ViFlEnmq9HU1GaFyPXFSvd3HBFFywvnMA4SpSOtVrVA7JZnI2sKC3BXhJlG1Z2VSt05IlelkwjpPkM0nPInDFBN5w8s+4/aPa4eMtzyewRbCoY35O/tmLWFIjcZ1Yn5ypKb1VWyfY8cse1wiAmPvT7aHnv4mJnQfL4dw6MMnomuWXe8dnHWxp/OOCf95c2dprvuP6Wtdf5rhz6Dsi2XuTXnwNJ7Lr/cJzefiZt/UfASne9BcAFJ2sEh86czGAMwyBgfwy35Gu+/TQ75e2m7NHA== X-MS-TrafficTypeDiagnostic: CY4PR1201MB0054: X-Microsoft-Exchange-Diagnostics: 1;CY4PR1201MB0054;31:aSl+0BjacayXc825k9q+1uFWUngM+T+kpOtACJjhNw/eA6CsAiCP2UbSBIHNup6XDH7sf/nni83TO2v+5DI9+CWpEDKmDgwcxG0srs3BO/BUn2UykvrwWLMjjUps4BKlpC6INSkEtm43lhMjJKwoqXez1e5auqmNxYRifW6VZoQX9Z4PhW/J4luTz5EKv7S+2VBp6rqtzCXWwfnXiRAYMPzwRDWfmOGIZG68vxN2Z68=;20:hEwFv/CS8DNuSgskvbscZEK5GQZJ26O+JXKB9eLSuEbMjyb2YB6+bWr3Z7cc9cdwoU7LcwfxQ/6bU1boSMMtpQvPVR/jzfDUESEqhbPVQpJSydKE7TyRGgVNOpp6Z4dYgJ5TWh6oUm6IA6q5OTwLDddXYWoqvaXwJsT0wzTEb5gekXDdUmbav3GCMmVIeWlhrpdEw2dpIxl8pbYmSxDm3FNfp0P2/q02UnzCuqqoBVHT36L8d/TLv9BM0WyIaP1FkICWAeRd+yPw34T0N0J4MwNhXncKxYokyBMY4TKLwHh0Xr6cSXef9DKI4BtKvH3P5W/WsInCnpq8bxNPjVnp5a39FW0w7+NRIAShJ3DXqJsDPYh/f5icteoCMr0t0FNYgceZrDGA/TFRG1FNQlGfFc+8WMjQ10jxjYAljVn1pT0M/DlCm43XrScj9zPC+NsmuwxgFJHh1LuQXuG7apNNNAspbtDwEASfKkGu2Vbjrfs/hHJlkxMwDFwV5faCEhGl X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93003095)(3002001)(100000703101)(100105400095)(3231021)(6055026)(6041248)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR1201MB0054;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR1201MB0054; X-Microsoft-Exchange-Diagnostics: 1;CY4PR1201MB0054;4:LnkKK010Gp9mcNyF+h/iijszeOsUoggvYh3SRW+QPAErE74QJMaGFzN2E7IOg2LXufoCljXUCdVYGg0/BA0+Z7l9x6OUWXdtYlkOzUPQurcXZDXrhvr+YzteScoyy1JkXEbsR+D+BVtZscpo6ddpyEK4mTA7ekcVwRx4yXafQGXIxnGMeSpCx+8bTR3CY0D59XGka6UE9U8QqI31S9cMfsslKfbcGsDToe9J3dTbgHWf3wHqAqkOZEYYwmw77ZvsavJtMImkOuQzM5MR4yVguw== X-Forefront-PRVS: 0484063412 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY4PR1201MB0054;23:GHMvgy1/7duUsT+pArgZHFqaowSxIpTlFYqwvdU?= =?us-ascii?Q?Fl0Ho4mi7ttG0xVEN3IL2XR1EqeThHVMJJpkB+wzIsvGAeCratFJOpmGB+2G?= =?us-ascii?Q?dpipSaykgYndaoFoNvJZvpVjltVgJSSWcGKfavN/me9jdzQMuCBctun/J1aL?= =?us-ascii?Q?AW9eILgDRduD6VP3+ry2a2Pqhv0YBcZcF5UJVc/InS9sXvKs+636xn9OMgim?= =?us-ascii?Q?2nnms7s7HnUw678zhYlXUQkMoR08axYLbaXAQr0HMM2v9qiOb1VJff4Rdy71?= =?us-ascii?Q?/RR07XFLMvlILq7uXop/D1YR/3Pcxel3dG+qpkC7E4VEvO6lcGFgEQupONgn?= =?us-ascii?Q?ZvxRWp2Yam9X2ea5l5Yn1BJ3Pq5ZRHCb7FgESaO3OwcfD5Aar50wIkcCf4Tc?= =?us-ascii?Q?NesGlZ6GGayXj/J8YaN0nTSh9i/0FeKsCOmquq57sVRtMuIEm+f0XThMWTCq?= =?us-ascii?Q?N1HAdkEFViUin7MwkuhjoO/2yTegULQDAYrNxEApwnGGtPno65P+ggTa3/+K?= =?us-ascii?Q?H36vgQSKEZnzNRG8W5cmDlVj86UgtAZUjOXbx6s6VKUJCQlT/ttePmbaecYy?= =?us-ascii?Q?AbR92ve++TcfHY78a7fkXCdMX9Ao/BT9qbRl4Om634hYBo7ZkS80kgq9PF2T?= =?us-ascii?Q?R4cFI1XEEGdMgctI9AgHGLI4JeU0mlVsFH5ifLE66duFyGb/Faj0VSMgPmyW?= =?us-ascii?Q?xFfM1ObExwonXvRKBsLl67geMQLJMQxzkr/awm/7mUE7qbdMAxE0WDrIgfYN?= =?us-ascii?Q?rpGskLevucMAxyhZ10LdycH3FJW5g//pkHQyp2cet5OS8FLWE0xTrUwG9ccE?= =?us-ascii?Q?+jWJwDKWXF8Q72DelJQ51/bn4gr8zJu0Xka9ckLveCU6GkOFk5AQ2PF0oHoP?= =?us-ascii?Q?pjkqE9fsZDKi0Ij+KadC4O+bqcYzCIBYpCuYqFPmylbf0iqycboPr7m9aWho?= =?us-ascii?Q?Ri1mkkeIuWffUYhziMapoJBuA4eke8dZdvGx/1deLrPJ2w9jWzV0rqiBG1Kt?= =?us-ascii?Q?PZXGGSsL18PC45E68ouLR3CkPMVYEgBWTEWG8uPp+51/8zhg4ll3Nl1SNJ4O?= =?us-ascii?Q?yAYkozPHSkCWQghFNflYvyYhp7t8a7ukurGB4VRjL3wW7Okj9OwewUVh1H6S?= =?us-ascii?Q?diQJnr2yknio/s9ygJtxeDg6ucbwwfCNfW8EzOfSSCX2yaDsKre4R5bojYTp?= =?us-ascii?Q?G9HbheEmNROANUIDAs+7YraSoJ/ou5dNIUPeNWFNhE0ph377ZiU2JIsml2Sz?= =?us-ascii?Q?PvfhUIEvk4t1vsiYDFz8bUAnlrxz7lnoiMd2lP0PW?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR1201MB0054;6:BmYt3dkkwELn2PYqbhkQp1ci4KTZilU6XdGJEMBoXyBbBjbRJAQR/B/CsP1cIUfiGNsF2yGTnH4q/5f3rTF7CyBBTdy3C48ZQGq5Pn6CQjL/cb4BfvGZkWxlH+IDYrg25atGg9dyvfu9RB/qhlpe61Bk0Sbwqa7vZC4NTvE6Db/w3mxXAj/eEVAvuxYw6ELkT8JAblLBMT2QMIizIGVW1J/WAS4XKP/3jhDSni/Na6uvRSV5ThQCjMy8EjRHegUcuEh0V08Ec+rPQfMkqnpirDt2h/mPbmoFKb9cBrxF63LRKZr6s26KXZr9fr+9BezibOkAKq9VgSqLAK0tcoF2xIJTxy7m14xy5H7rm2o8/wI=;5:VLfVAxRDY7EqgthGmldBWaDGedQmzT19HoZTuNwvakxrK42YkaxoKn/J2eH2F6Gi+neKRYA0UanxddnY6Ar3XPXJ3CT+/6a6iQ5e30xC5lMXP5fVRdf7TBK/jkDeSQLN4u3nnMw4rjGFzkZTVi5gf45GhJJq3IOc7P5sXGFqbxQ=;24:qEcB0nDxWZ5nDkXvvdQ9FJYXSUtdsnwY+ndGicYTAc0N+nu4v6Y2hFslo+N7fpluamhO5Afmzbu8DA70nxI7c5sNNs4TBRPDYkNYMrcR/Dk=;7:GY5+KYBKreZ5tz5lG55+8X+HpMD9xxvnu3BHrdg6mcV6HXr4d2cOvGiaKqazgcfkwKFGc/D+vhdJeTGJmwFvDDpZIw0wZzEuzgybQ3RmD24gfnfyNNF4bsSWgdJtGxe3RkeH0ibyzrzIcg8c5nyMKC4SNhkx7qRkOAJHESNNnmh3bizoCEtNgbnSVZ8DLHaFjpS0t6fHe3oiaUSoQSBBAvnAIQOH+kM7CLj6sAY+uLFLAzbQdrMFqaKs1HQ/lFX8 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR1201MB0054;20:lV8wNvLnZ76TgIj6LWSLa1ciiQpOhXGd0y3lJRoYLa0wwMGCPGedyVT9qe64SgqU5m8Qlt7Dg9kOLlQiCedAZo4Om893GyyVFQotHY9ejQR/JCm4i94UduJymzESveTgnMIxZnbYnSZ/yy+FecK248Hs2DHHKl1TSo3X7nE0qhHkKQPmProauUm2nBv3IbQo0g2leExc1zLEC9pMXibn8DWgwRcIaRSm4bCUvloa+rbHlnFSe52PdlyaPRhVMB9f X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2017 12:50:03.6434 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3c711d82-4a1a-4556-329f-08d525de10d0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXCHOV01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB0054 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On Fri, Nov 03, 2017 at 11:33:56AM +0000, Mark Rutland wrote: > Hi, > > As a heads-up, I believe that arch/x86/events/amd/power.c is currently > missing initialisation of pmu::module, which could result in problems > when the module is unloaded. > > We've just spotted a similar problem in a couple of ARM PMUs, and AFAICT > the AMD power PMU is the only other PMU affected. > > Other modular PMUs all initialise this to THIS_MODULE prior to calling > perf_pmu_register(). > Thanks to let me know. I have dived into pmu for quite a while. Could you please share more information or forward related mail thread, so that I can repro this issue in my side. :-) Thanks, Rui