From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753835AbdKGMxt (ORCPT ); Tue, 7 Nov 2017 07:53:49 -0500 Received: from mail-bn3nam01on0078.outbound.protection.outlook.com ([104.47.33.78]:53999 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750985AbdKGMxr (ORCPT ); Tue, 7 Nov 2017 07:53:47 -0500 Authentication-Results: spf=none (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=permerror action=none header.from=amd.com; Date: Tue, 7 Nov 2017 20:54:44 +0800 From: Huang Rui To: Mark Rutland CC: Subject: Re: perf/x86/amd/power missing pmu::module initialisation Message-ID: <20171107125443.GA11101@hr-amur2> References: <20171103113355.trx34ebuyhw7bej4@lakrids.cambridge.arm.com> <20171107125046.GA10337@hr-amur2> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20171107125046.GA10337@hr-amur2> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:165.204.84.17;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(376002)(39860400002)(346002)(2980300002)(428002)(199003)(189002)(24454002)(1076002)(23726003)(106466001)(105586002)(33656002)(33716001)(478600001)(6666003)(2950100002)(6916009)(5660300001)(6246003)(9686003)(53936002)(4326008)(72206003)(8676002)(81156014)(81166006)(8936002)(83506002)(68736007)(356003)(2906002)(229853002)(77096006)(50466002)(47776003)(97736004)(305945005)(55016002)(46406003)(189998001)(58126008)(316002)(86362001)(101416001)(54356999)(50986999)(76176999)(97756001)(16586007)(18370500001)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR1201MB0061;H:SATLEXCHOV01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DM3NAM03FT020;1:BK1N4A+LOUAqgvc08n7pK0W3rXmK2IVARQTGRgSyb5O7jXlsR4idOtWs6VTPd6qZVBLhMEQt+TJvOL0Q0tRBHKmU80VJLlALI4TCAxUPWod++Z7F0jVQagaZF0PtV9/v X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a39654cc-0d6c-4c52-dd90-08d525de93e6 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:MWHPR1201MB0061; X-Microsoft-Exchange-Diagnostics: 1;MWHPR1201MB0061;3:pDpvOxwCD4HEYHHocfZdSY4KOrGYyijKIy54FCyJxfJwZrIaTMislh4QqU/QBtQE4m+xIfLKBOl+D4AZqrh0gSTbQ4AmX/G3hzSCBrrHFV4j1/qS+4UgXaWKNZ1uukp44SZSSao4QdkVP9js2C+jjhxR8ZC/KBG3I9Z/mtEwtczrB50OJd6DNARi0fOOQdGFwxt5LUThaAbyclZQmay7SOpX0NGrggPhAVOD5SwfSNwtr4YOfsOxOL+o8y3Tf8GbZ5+yqNOerMBNn/PWJ0hMWXNxBAs+9os1+HbhxZukmq70nEsiqrEnGiOKiYo6Ak2Ocnz9aKR4v+cyp0P0/+Lj9WUKtJbQNYfFYQW1SIwY2eQ=;25:GDndUbESu618YvB9wWG141Fokd2+SpVsmdcntcVZwe34VHV31YKUcWmMW32N8nBbNmpQbB7omGBYHYV7brWJtiTmu4MvJXP2nqLNJMCpS9fqSrXqOk/i7mkeuEOR6kszyKIK2ja/+qseud58p6uiS1LKgelHYqhlGp0FLSdgbYpbUOnJWYxGbgaG2pyl2NZZZWDMw0PsS8UOLz0qBfRb1Q+fT0ndi69hUBgIoaAxoTD23PCR3fBr993Bvz3yPQok2XKsOl0L1XktAjkL9RlG6xdbzI5Fnzq1zosY3S4bRmSx/Fa1bQC+xtM1u61c1kEYv+k5onl/fiMBln8ctmZEJg== X-MS-TrafficTypeDiagnostic: MWHPR1201MB0061: X-Microsoft-Exchange-Diagnostics: 1;MWHPR1201MB0061;31:Ykz0s/sXie94jBrGyYM7fF98+ySG2ve+yp5VJYVGfi5XPgNy4Z6Qfx3A2y/tObNVXsdawwn/onl0EjE/hIni+cOgv9u0BeCfO6CFBo6TbPD7VrzRUfh7ae/DKnHdJXhQV9MD+AFC0ova3sPXU4qRD+G4KXxkCWrFLTSCbv5bgbLgIzP8TIxVS/65bQ2hsKM+KllTL3+RyGb34qsxaSKYN4BvuoK//IzHSw9CE8e/7VA=;20:aHCyksAkAaMjl2mN8YRSVLT6T8jrNhr6zpKsbmZNPGfIvGEAyeHTyLCcmLsxq+z50V4VMQj15ZWxXrlrnji7Q27pgmf0VShyAKmK7APFnuxw5E2zI33UAwasHyj45eSrhjrXtyIQfrsJ44te8E1Rn9LDUY18xZSNJt92ScW+EX2EO/NQgCw5qnqr8zxnkoCgHE9QcC+zymN5fhz42LewnhRpnBfgxTLvSFCf92Q1cHMyxaBN/Pb85MO4z41Ck88nyE2EtiMLDyRiqGze8z+bL7Crih1EhCaTdgsBwdMMoyu02J5d0djW1rkMdnHLg/8ga10pk+ju6iCNzdotmvgqzDy/QRS+GrEiN2g4e8dXBqKVIcfTkRYiVYI0V6r3pUMGMC/ViutofM9gpZ5Wc1sY7BhRxRHCSJlLxTpqxJmGDapWGETRtLOEtw7xmvkC/F0O59TpboVYgi/66dkZkWU0eWlL9zZRG6LeX035cq94KiCMa9wAlhxPj8bmVAUn3wgb X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(100000703101)(100105400095)(3231021)(93006095)(93003095)(6055026)(6041248)(20161123560025)(20161123562025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR1201MB0061;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR1201MB0061; X-Microsoft-Exchange-Diagnostics: 1;MWHPR1201MB0061;4:WxWqi2QKZqfeIqT9UPLY4aiap8V0/xO92zvrSrJV//a+hM38Z0MHlOBeI7ulKrjRVF7JzNfbI/wnYsLagcO/2a34uZLG85WSOJnQmiq1VLL/H7sTmMoGPAqxRiPbSP4fOcdeTlv85AHaTG6QDden0vRuy7KmJSDhFKUDMdJ2NGiSDGL/XafPhArIa/3KUB4OPDsSV6Pmv/EFLrZLkQl9KajxImzXMK3aPtUSIpw4SLbjWpggfplQiceFPT1Gz/BknjvIfNECPURRnin8xZznEg== X-Forefront-PRVS: 0484063412 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR1201MB0061;23:mAuIBroUCrJtihR6KBpEKUYCEpmEoFmZHVmmSsM?= =?us-ascii?Q?xbkCkc/5wtxb4wI42kEVURqAifCeWzrcGhwkfDpYcJbnL8ze9raQRuNoIg6z?= =?us-ascii?Q?/jwm1nrANQl+9IuiSskQnt5gmnlrabT0Ndj12kf3KuneIxoVVcgW8n4e7aHP?= =?us-ascii?Q?1h9zdNYv4kPMsnm39JOP/2ApxC7DHMwTDuEvlSzCRTHtPIU7yRIsvYewcH18?= =?us-ascii?Q?mr161Mrq8lQcIeVSZUEvOm5bTe9QCejmiAEsBSeWu9jgyWdwB/Zehm3efadx?= =?us-ascii?Q?YQftBSgwzjxBQT+8MkzvjrOlIHfx1PagUeMJB8dsIiOYvN7eXbhCmAg5AfBH?= =?us-ascii?Q?5j/mrVXhMJGr+OdULhXh5WbTElFULGqlBflIiI/W0MrlKMHN1GC0qUKO24Xk?= =?us-ascii?Q?Tn+Box4PFlSa5QQ/hr9QFyrjxao6zjCtDwfZH0/KFELDRZnO9Py/+HeXRV8C?= =?us-ascii?Q?Z3B3+KGv58wHC06/0zCwy01qmlJ7htTCkUs1k7GQ3TcuBspH9OEbnqqhALEp?= =?us-ascii?Q?18YcMJBwvYBnmy3bNnc1gS3ejp5BFRvh7g/ZKYJzkBRjD4yPCj7lfRD+8xkG?= =?us-ascii?Q?jUcJ5aM5goZ1GMO4O0rcvypOe7/C1ilA/M7vieCbErQxxMhqS+Jv3WNOZ2o7?= =?us-ascii?Q?oQ2fVHjtEDlnK+3EJft4jfsGy5IrUW6/0o78LADy/jwvQjntmimMa81glrwW?= =?us-ascii?Q?4lGIjEVic8SaQrXVnln3FA8yRBza9B9h+NlzNZq/KN+359/S/LAnq4t2s2J4?= =?us-ascii?Q?5eGWmDgDsAK3sKJtFv4vuRh703Cx1ANJcpqqIil97t1ErsaMz/A/DW19278Q?= =?us-ascii?Q?+DFNeBRK+sJwspmutM2K1uIhw+z5Vi4ZP6fFTTJ4MEXA6SBOEiDMb8z6RYOc?= =?us-ascii?Q?QkvXXGSIMx6WCUikLD5i1I1kLtIh4V897PVPat9HdxyKg7pJ+i95WxTnSbMR?= =?us-ascii?Q?+TZ86FpeEKp3JQXYRSi3UfXQZIkC5zk0f5qiEYUoNSUEKB3aosEpG0BZOdYG?= =?us-ascii?Q?amKlE3C29PZYNcfNpXaSAmpgrN/C1o6EZ/PH8EOmyCmTIcGG6IjMw80IioZu?= =?us-ascii?Q?z84wDSzyMenRhD4Kq5MFVnAF9UJlg+5y+wr0xeoZHHynPLA7B2wudTJZmFQM?= =?us-ascii?Q?ht9rp9yyYPpqblN69n4xZpyl9xApcDeEg5CQPLkvso1zHbn7L/LuLDW88lHi?= =?us-ascii?Q?k4yI1zcKz8TZdTh/wDgMEZzagvSuOalwSzXgiSezu6K/4NiCB2Xd8n/YLcg?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR1201MB0061;6:LiDNENYRRgagGHC2+VUVt9SAJAfn92CPHZudeOxTDnsalMLWiSkncCDQ3rBuJWZeJtZ55de1erkmoQoL48PXAZDHAlvl2lT0g9sYivNQLsDuuiuCZpiytzVR2iXY61bfp4RW/t3UfYIOOYasxMx2W6xOZv4ur8xekgIx9G9vus9QLh3HntOn2ElV5U/NFixwNW+b+1jd8S4p8XPp6SPb92iMrOo7BVx1p1HlvKQ1jGgN6yGyLoq+ya7wBzUSHU3iwN09GyuVZzZM36CJZvcktnhYIVAeoulon6DeyHgvhfgZvsRX8Loh5phyD/+4dpkD1MNOm21a/vhdKSmgWbi8arQPuPIv+0QrjOSgBG3xz3c=;5:VLGeNks96D7Fu75uhsK+3v3QaesQKfUoGR5DpbsV+SvjLiIiKjpRjlk9zi1L5UKH4CGDYzzO3lXA2HSuA8TKMCnni4o3LQa7wMP5x+dxxBdfX84uZ+FpmtSXXO8GyIudbM6uTU8yGPppppBQCBxLXPjzJeP4pBZ6Okvb8mMkRVY=;24:e30bjmWe9UL2WA9pVGu3bqNobuo9NVyRa99pEA8cLl4S6M5w80OPe2a7A7HrOV+H2GTY5gLTlUCeRJkZ2SOvgSQjxMAl8wMefotJtwF1dX0=;7:3EqGqT5cFOQ2NTDN+PfHtmZ22DGdJXr0/dPuVWp8Gxrq22jny03d6lH/b8aYYw3bjGzsaPSQaVZZWidMhRuq9HT24ey0YUgtbntwQDfinoZUK7J0tWIbSd1I6dZmu1yJRzNLMERgvyy248x39L/PAu+A3zB9t0u9HmOJEPKZ9gTIv2hxt7kYlzKQexUgK4RftIivdLtDyaRC82D/C+1cqcjE5kNI787KgIc/PvKbdYs4KUyyWCdawM8WOshB5YYk SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR1201MB0061;20:Up5DVJxctqeCiNmjestGrP+yLW44iCVJ83ynf4cnHPvXgoqw4vSEDNIaj34tpl9Sm0c0owKKbW1b1qoDkqJllV/p7IJ2kz0/r1X4ymx1VJo30um+662wAz5Ps2TsG8lNI8VBIVNfXb54LTb2SD202R0MlVieL6ogwL50aPmudyFa4DLNZvsCcR/t91xPoPwBX7+5A5O6Dwn+2Dm+z8Im/Tlicu1yh2Z2XHxWJ8VE/G58SidU8ykigWUyr8prNgtM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2017 12:53:42.9641 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a39654cc-0d6c-4c52-dd90-08d525de93e6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXCHOV01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB0061 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 07, 2017 at 08:50:52PM +0800, Huang Rui wrote: > Hi Mark, > > On Fri, Nov 03, 2017 at 11:33:56AM +0000, Mark Rutland wrote: > > Hi, > > > > As a heads-up, I believe that arch/x86/events/amd/power.c is currently > > missing initialisation of pmu::module, which could result in problems > > when the module is unloaded. > > > > We've just spotted a similar problem in a couple of ARM PMUs, and AFAICT > > the AMD power PMU is the only other PMU affected. > > > > Other modular PMUs all initialise this to THIS_MODULE prior to calling > > perf_pmu_register(). > > > > Thanks to let me know. I have dived into pmu for quite a while. Could you Fix typo -> "I haven't dived into ..." Thanks, Rui