From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965280AbdKGPF7 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 7 Nov 2017 10:05:59 -0500
Received: from mail-wr0-f195.google.com ([209.85.128.195]:50640 "EHLO
        mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S965164AbdKGPF6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 7 Nov 2017 10:05:58 -0500
X-Google-Smtp-Source: ABhQp+Qn4yOwx4KMXsz4Hk5GtBsgzSuqhPLWDvj3zuSS4nIiPHVm8IcUnf8/XYsNgH6dHg9tWIe+Cg==
Date: Tue, 7 Nov 2017 16:05:54 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] objtool: Move sync check to a script
Message-ID: <20171107150554.sbyrdxq4rv4zfkyt@gmail.com>
References: <cover.1509974346.git.jpoimboe@redhat.com>
 <ab015f15ccd8c0c6008493c3c6ee3d495eaf2927.1509974346.git.jpoimboe@redhat.com>
 <20171107094621.kfpykhbncikmeyms@gmail.com>
 <20171107133108.ddwhwpa7b4bfrvmr@treble>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171107133108.ddwhwpa7b4bfrvmr@treble>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Josh Poimboeuf <jpoimboe@redhat.com> wrote:

> On Tue, Nov 07, 2017 at 10:46:21AM +0100, Ingo Molnar wrote:
> > Hm, this doesn't actually warn - it outputs the diff:
> > 
> >  triton:~/tip/tools/objtool> ./sync-check.sh 
> >  triton:~/tip/tools/objtool> 99a100,109
> >  > /* Identifiers for segment registers */
> >  > #define INAT_SEG_REG_IGNORE   0
> >  > #define INAT_SEG_REG_DEFAULT  1
> >  > #define INAT_SEG_REG_CS               2
> >  > #define INAT_SEG_REG_SS               3
> >  > #define INAT_SEG_REG_DS               4
> >  > #define INAT_SEG_REG_ES               5
> >  > #define INAT_SEG_REG_FS               6
> >  > #define INAT_SEG_REG_GS               7
> >  > 
> > 
> > I fixed it to do:
> > 
> >         diff $file ../../$file > /dev/null ||
> > 
> > (note the removal of '&')
> > 
> > Then it outputs the right thing:
> > 
> >   triton:~/tip/tools/objtool> ./sync-check.sh 
> >   Warning: synced file at 'tools/objtool/arch/x86/include/asm/inat.h' differs from latest kernel version at 'arch/x86/include/asm/inat.h'
> 
> Ah.  I guess '&>' is a bash-ism, shorthand for redirecting both stdout
> and stderr.  It worked for me with bash 4.4.12.  I guess you used a
> different default shell?

No, I use bash too, but note that the script uses SH:

  #!/bin/sh

Thanks,

	Ingo