From: Al Viro <viro@ZenIV.linux.org.uk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
y2038@lists.linaro.org, Deepa Dinamani <deepa.kernel@gmail.com>,
stable@vger.kernel.org, linux-alpha@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] alpha: osf_sys.c: fix put_tv32 regression
Date: Tue, 7 Nov 2017 15:52:22 +0000 [thread overview]
Message-ID: <20171107155222.GV21978@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20171107141029.3160278-1-arnd@arndb.de>
On Tue, Nov 07, 2017 at 03:09:24PM +0100, Arnd Bergmann wrote:
> There was a typo in the new version of put_tv32() that caused
> uninitialized stack data to be written back to user space, rather
> than writing the actual timeval for the emulation of
> gettimeofday(), wait4(), usleep_thread() and old_adjtimex().
>
> This fixes it to write the correct data again.
*blink*
the bug is real, all right, and the fix is correct one, but where
do you get an infoleak? What it is is a user-triggerable oops -
just pass it an unmapped address. For anything mapped r/w it's
simply a no-op - userland data is unchanged.
IOW, the fix is correct, but commit message isn't - it's
"user-triggerable oops and in all cases failed to modify userland timeval32"
not
"uninitialized stack data to be written back to user space"
next prev parent reply other threads:[~2017-11-07 15:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 14:09 [PATCH 1/2] alpha: osf_sys.c: fix put_tv32 regression Arnd Bergmann
2017-11-07 14:09 ` [PATCH 2/2] alpha: osf_sys.c: use timespec64 where appropriate Arnd Bergmann
2017-11-08 0:22 ` [Y2038] " Ben Hutchings
2017-11-08 14:54 ` Arnd Bergmann
2017-11-07 15:52 ` Al Viro [this message]
2017-11-07 16:03 ` [PATCH 1/2] alpha: osf_sys.c: fix put_tv32 regression Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171107155222.GV21978@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=rth@twiddle.net \
--cc=stable@vger.kernel.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox