From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752019AbdKHKnm (ORCPT ); Wed, 8 Nov 2017 05:43:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53344 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751829AbdKHKnk (ORCPT ); Wed, 8 Nov 2017 05:43:40 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BF37125C28 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Wed, 8 Nov 2017 11:43:37 +0100 From: Jiri Olsa To: Stephane Eranian Cc: linux-kernel@vger.kernel.org, acme@redhat.com, peterz@infradead.org, mingo@elte.hu, ak@linux.intel.com, kan.liang@intel.com Subject: Re: [PATCH v3 5/5] perf/script: add support for skid ip Message-ID: <20171108104337.GA1629@krava> References: <1510127797-22483-1-git-send-email-eranian@google.com> <1510127797-22483-6-git-send-email-eranian@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1510127797-22483-6-git-send-email-eranian@google.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 08 Nov 2017 10:43:40 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 07, 2017 at 11:56:37PM -0800, Stephane Eranian wrote: SNIP > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c > index 223165055d41..ee8fb635f694 100644 > --- a/tools/perf/util/session.c > +++ b/tools/perf/util/session.c > @@ -1133,7 +1133,7 @@ static void dump_sample(struct perf_evsel *evsel, union perf_event *event, > sample_read__printf(sample, evsel->attr.read_format); > > if (sample_type & PERF_SAMPLE_SKID_IP) > - printf("... skid_ip: %" PRIu64 "\n", sample->skid_ip); > + printf("... skid_ip: 0x%" PRIx64 "\n", sample->skid_ip); should be part of the patch 3/5 jirka