Re: [PATCH 5/7] scripts/leaking_addresses: add emailing results

Petr Mladek
2017-11-08T10:16:52Z

On Wed 2017-11-08 14:37:37, Tobin C. Harding wrote:
> Developers may not have the time (or inclination) to investigate script
> output. This information is, however, useful. If we add functionality to
> the script to email results for further investigation.
>
> Add --send-report flag to email scan results (to Tobin C. Harding).

I am not sure that it is wise to make spaming one person
so easy ;-)

It might make sense to add some more information into
the message. For example:

+ uname -a
+ whether the log was generated using root access

Also people might feel more comfortable if this feature:

+ prints the message
+ printks where it is being sent
+ ask yes/no before doing so

> scripts/leaking_addresses.pl | 42 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
> mode change 100755 => 100644 scripts/leaking_addresses.pl
^^^^^^^^^^^^^^^^^^^^^^^^^^^^

> diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
> old mode 100755
> new mode 100644

I guess that this was not intended.

Best Regards,
Petr