From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752685AbdKHOP1 (ORCPT ); Wed, 8 Nov 2017 09:15:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51010 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752655AbdKHOP0 (ORCPT ); Wed, 8 Nov 2017 09:15:26 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0535A25C24 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Wed, 8 Nov 2017 15:15:22 +0100 From: Jiri Olsa To: Milind Chabbi Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, namhyung@kernel.org, linux-kernel@vger.kernel.org, Michael Kerrisk-manpages , linux-man@vger.kernel.org, mpe@ellerman.id.au, ak@linux.intel.com, kan.liang@intel.com, hbathini@linux.vnet.ibm.com, sukadev@linux.vnet.ibm.com, yao.jin@linux.intel.com Subject: Re: [PATCH] perf/core: fast breakpoint modification via _IOC_MODIFY_BREAKPOINT Message-ID: <20171108141522.GA6320@krava> References: <20171106092305.GA16382@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 08 Nov 2017 14:15:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 06, 2017 at 07:04:40AM -0800, Milind Chabbi wrote: > Hi Jirka, > > I see the tabs in my sent email, do you have suggestions on how best to > send this patch so that the tabs are preserved by the email client? > Can anybody else also check if they received with/without tabs? > > release_bp_slot/reserve_bp_slot majic is not necessary since > _IOC_MODIFY_BREAKPOINT ioctl modifies an already registered breakpoint > without affecting the count of breakpoints active. but AFAICS you allow to change the breakpoint type (bp_type) and slot counts are based on the breakpoint type jirka