From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752741AbdKHOTW (ORCPT ); Wed, 8 Nov 2017 09:19:22 -0500 Received: from mga11.intel.com ([192.55.52.93]:46687 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752361AbdKHOTV (ORCPT ); Wed, 8 Nov 2017 09:19:21 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,364,1505804400"; d="scan'208";a="171086594" Date: Wed, 8 Nov 2017 19:52:33 +0530 From: Vinod Koul To: Peter Ujfalusi Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH RESEND] dmaengine: ti-dma-crossbar: Correct am335x/am43xx mux value type Message-ID: <20171108142232.GY3187@localhost> References: <20171108100225.25024-1-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171108100225.25024-1-peter.ujfalusi@ti.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 08, 2017 at 12:02:25PM +0200, Peter Ujfalusi wrote: > The used 0x1f mask is only valid for am335x family of SoC, different family > using this type of crossbar might have different number of electable > events. In case of am43xx family 0x3f mask should have been used for > example. > Instead of trying to handle each family's mask, just use u8 type to store > the mux value since the event offsets are aligned to byte offset. > > Fixes: 42dbdcc6bf965 ("dmaengine: ti-dma-crossbar: Add support for crossbar on AM33xx/AM43xx") > Signed-off-by: Peter Ujfalusi > --- > Vinod, > > this patch somehow got missed, I have sent it in May: > https://patchwork.kernel.org/patch/9736747/ not sure how, but applied now -- ~Vinod