From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
David Ahern <dsahern@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 3/3] perf tools: Removing FLAGS_PYTHON_EMBED/FLAGS_PERL_EMBED variables
Date: Wed, 8 Nov 2017 13:06:40 -0300 [thread overview]
Message-ID: <20171108160640.GE4333@kernel.org> (raw)
In-Reply-To: <20171108102739.30338-4-jolsa@kernel.org>
Em Wed, Nov 08, 2017 at 11:27:39AM +0100, Jiri Olsa escreveu:
> There's no user of those.
[acme@jouet linux]$ find tools/ -type f | xargs grep FLAGS_PYTHON_EMBED
tools/perf/Makefile.config: FLAGS_PYTHON_EMBED := $(PYTHON_EMBED_CCOPTS) $(PYTHON_EMBED_LDOPTS)
tools/build/feature/Makefile: $(BUILD) -fstack-protector-all -O2 -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma -lelf -laudit -I/usr/include/slang -lslang $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null) $(FLAGS_PERL_EMBED) $(FLAGS_PYTHON_EMBED) -DPACKAGE='"perf"' -lbfd -ldl -lz -llzma
tools/build/feature/Makefile: $(BUILD) $(FLAGS_PYTHON_EMBED)
[acme@jouet linux]$
Should we remove these?
- Arnaldo
> Link: http://lkml.kernel.org/n/tip-84jeuwojm21wcjfzvtis636l@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
> tools/perf/Makefile.config | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> index 5e3734e4c1e4..caa7fe26efa9 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
> @@ -187,7 +187,6 @@ ifdef PYTHON_CONFIG
> ifeq ($(CC_NO_CLANG), 1)
> PYTHON_EMBED_CCOPTS := $(filter-out -specs=%,$(PYTHON_EMBED_CCOPTS))
> endif
> - FLAGS_PYTHON_EMBED := $(PYTHON_EMBED_CCOPTS) $(PYTHON_EMBED_LDOPTS)
> endif
>
> FEATURE_CHECK_CFLAGS-libpython := $(PYTHON_EMBED_CCOPTS)
> @@ -580,7 +579,6 @@ else
> PERL_EMBED_LDFLAGS = $(call strip-libs,$(PERL_EMBED_LDOPTS))
> PERL_EMBED_LIBADD = $(call grep-libs,$(PERL_EMBED_LDOPTS))
> PERL_EMBED_CCOPTS = $(shell perl -MExtUtils::Embed -e ccopts 2>/dev/null)
> - FLAGS_PERL_EMBED=$(PERL_EMBED_CCOPTS) $(PERL_EMBED_LDOPTS)
>
> ifneq ($(feature-libperl), 1)
> CFLAGS += -DNO_LIBPERL
> --
> 2.13.6
next prev parent reply other threads:[~2017-11-08 16:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 10:27 [PATCH 0/3] perf tools: Build fixes Jiri Olsa
2017-11-08 10:27 ` [PATCH 1/3] perf tools: Use shell function for perl cflags retrieval Jiri Olsa
2017-11-08 16:03 ` Arnaldo Carvalho de Melo
2017-11-18 8:26 ` [tip:perf/core] " tip-bot for Jiri Olsa
2017-12-18 17:15 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2017-11-08 10:27 ` [PATCH 2/3] perf tools: Fix build for hardened environments Jiri Olsa
2017-11-08 16:03 ` Arnaldo Carvalho de Melo
2017-11-09 7:36 ` Jiri Olsa
2017-11-09 12:52 ` Arnaldo Carvalho de Melo
2017-11-10 9:43 ` Jiri Olsa
2017-11-23 14:15 ` Arnaldo Carvalho de Melo
2017-11-23 14:38 ` Jiri Olsa
2017-11-29 19:54 ` Arnaldo Carvalho de Melo
2017-11-29 20:00 ` Arnaldo Carvalho de Melo
2017-11-30 10:08 ` Jiri Olsa
2017-12-01 2:11 ` Namhyung Kim
2017-12-04 7:34 ` Jiri Olsa
2017-12-04 8:24 ` Jiri Olsa
2017-12-04 15:35 ` Arnaldo Carvalho de Melo
2017-12-05 16:19 ` Jiri Olsa
2017-12-06 16:40 ` [tip:perf/core] perf tools: Fix up build in hardnened environments tip-bot for Jiri Olsa
2017-12-18 17:16 ` [tip:perf/urgent] perf tools: Fix up build in hardened environments tip-bot for Jiri Olsa
2017-11-08 10:27 ` [PATCH 3/3] perf tools: Removing FLAGS_PYTHON_EMBED/FLAGS_PERL_EMBED variables Jiri Olsa
2017-11-08 16:06 ` Arnaldo Carvalho de Melo [this message]
2017-11-09 7:27 ` Jiri Olsa
2017-11-09 12:48 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108160640.GE4333@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).