From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753129AbdKHTuU (ORCPT ); Wed, 8 Nov 2017 14:50:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40442 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753060AbdKHTuS (ORCPT ); Wed, 8 Nov 2017 14:50:18 -0500 Date: Wed, 8 Nov 2017 21:50:17 +0200 From: "Michael S. Tsirkin" To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Christian Borntraeger , Cornelia Huck , Martin Schwidefsky , Heiko Carstens , linux-s390@vger.kernel.org Subject: Re: [PATCH] s390/virtio: mark headers as BSD licensed Message-ID: <20171108214928-mutt-send-email-mst@kernel.org> References: <1510159613-12930-1-git-send-email-mst@redhat.com> <20171108172844.GA9893@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171108172844.GA9893@kroah.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 08 Nov 2017 19:50:18 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 08, 2017 at 06:28:44PM +0100, Greg Kroah-Hartman wrote: > On Wed, Nov 08, 2017 at 06:47:18PM +0200, Michael S. Tsirkin wrote: > > Virtio UAPI headers aren't just for UAPI, it's for guests/hypervisors as > > well. The s390 ones need to be BSD as well. > > > > Fixes: e2be04c7f995 ("License cleanup: add SPDX license identifier to uapi header files with a license") > > Cc: Greg Kroah-Hartman > > Signed-off-by: Michael S. Tsirkin > > --- > > > > Christian, I would appreciate your ack if you agree. > > You are changing the license on this file, you can't just slap a BSD one > on the top, and have GPL below it without saying something about both > covering the file, right? > > > > > > > arch/s390/include/uapi/asm/kvm_virtio.h | 26 ++++++++++++++++++++++- > > arch/s390/include/uapi/asm/virtio-ccw.h | 37 ++++++++++++++++++++++++++++++++- > > 2 files changed, 61 insertions(+), 2 deletions(-) > > > > diff --git a/arch/s390/include/uapi/asm/kvm_virtio.h b/arch/s390/include/uapi/asm/kvm_virtio.h > > index 7328367..1773693 100644 > > --- a/arch/s390/include/uapi/asm/kvm_virtio.h > > +++ b/arch/s390/include/uapi/asm/kvm_virtio.h > > @@ -1,4 +1,28 @@ > > -/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > > There is a dual-license SPDX identifier you can use, please use that, if > you agree to relicense this file. > > thanks, > > greg k-h Will do, thanks. -- MST