[PATCH] x86, build: Make genimage.sh little more quite

[PATCH] x86, build: Make genimage.sh little more quite

[changbin.du]

From: Changbin Du <changbin.du@intel.com>

This change suppresses the 'dd' output and adds '-quite' parameter
to mkisofs tool. None of the messages matter to the user. Now:

$ make isoimage
...
Kernel: arch/x86/boot/bzImage is ready  (#75)
  GENIMAGE arch/x86/boot/image.iso
Using /usr/lib/ISOLINUX/isolinux.bin
Using /usr/lib/syslinux/modules/bios/ldlinux.c32
Kernel: arch/x86/boot/image.iso is ready

Cc: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Changbin Du <changbin.du@intel.com>
---
 arch/x86/boot/genimage.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/boot/genimage.sh b/arch/x86/boot/genimage.sh
index 628e936..86e2639 100644
--- a/arch/x86/boot/genimage.sh
+++ b/arch/x86/boot/genimage.sh
@@ -50,7 +50,7 @@ genbzdisk() {
 }
 
 genfdimage144() {
-	dd if=/dev/zero of=$FIMAGE bs=1024 count=1440
+	dd if=/dev/zero of=$FIMAGE bs=1024 count=1440 2> /dev/null
 	mformat v:
 	syslinux $FIMAGE
 	echo "$KCMDLINE" | mcopy - v:syslinux.cfg
@@ -61,7 +61,7 @@ genfdimage144() {
 }
 
 genfdimage288() {
-	dd if=/dev/zero of=$FIMAGE bs=1024 count=2880
+	dd if=/dev/zero of=$FIMAGE bs=1024 count=2880 2> /dev/null
 	mformat w:
 	syslinux $FIMAGE
 	echo "$KCMDLINE" | mcopy - W:syslinux.cfg
@@ -103,7 +103,7 @@ genisoimage() {
 	if [ -f "$FDINITRD" ] ; then
 		cp "$FDINITRD" $tmp_dir/initrd.img
 	fi
-	mkisofs -J -r -input-charset=utf-8 -o $FIMAGE -b isolinux.bin \
+	mkisofs -J -r -input-charset=utf-8 -quiet -o $FIMAGE -b isolinux.bin \
 		-c boot.cat -no-emul-boot -boot-load-size 4 -boot-info-table \
 		$tmp_dir
 	isohybrid $FIMAGE 2>/dev/null || true
-- 
2.7.4

Re: [PATCH] x86, build: Make genimage.sh little more quite

[Ingo Molnar]

* changbin.du@intel.com <changbin.du@intel.com> wrote:

> From: Changbin Du <changbin.du@intel.com>
> 
> This change suppresses the 'dd' output and adds '-quite' parameter
> to mkisofs tool. None of the messages matter to the user. Now:
> 
> $ make isoimage
> ...
> Kernel: arch/x86/boot/bzImage is ready  (#75)
>   GENIMAGE arch/x86/boot/image.iso
> Using /usr/lib/ISOLINUX/isolinux.bin
> Using /usr/lib/syslinux/modules/bios/ldlinux.c32
> Kernel: arch/x86/boot/image.iso is ready

Could you please also remove the other unnecessary lines as well, from the default 
build log:

> Using /usr/lib/ISOLINUX/isolinux.bin
> Using /usr/lib/syslinux/modules/bios/ldlinux.c32
> Kernel: arch/x86/boot/image.iso is ready

The build process is using a ton of files and we don't list them. Maybe print them 
when V=1, but not by default.

The only lines printed should be:

> Kernel: arch/x86/boot/bzImage is ready  (#75)
>   GENIMAGE arch/x86/boot/image.iso

Users are totally not interested in the details. They want to see a single line of 
output about which file is being built, but that's it.

Thanks,

	Ingo

Re: [PATCH] x86, build: Make genimage.sh little more quite

[Du, Changbin]

[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]

On Wed, Nov 08, 2017 at 10:01:37AM +0100, Ingo Molnar wrote:
> 
> * changbin.du@intel.com <changbin.du@intel.com> wrote:
> 
> > From: Changbin Du <changbin.du@intel.com>
> > 
> > This change suppresses the 'dd' output and adds '-quite' parameter
> > to mkisofs tool. None of the messages matter to the user. Now:
> > 
> > $ make isoimage
> > ...
> > Kernel: arch/x86/boot/bzImage is ready  (#75)
> >   GENIMAGE arch/x86/boot/image.iso
> > Using /usr/lib/ISOLINUX/isolinux.bin
> > Using /usr/lib/syslinux/modules/bios/ldlinux.c32
> > Kernel: arch/x86/boot/image.iso is ready
> 
> Could you please also remove the other unnecessary lines as well, from the default 
> build log:
> 
> > Using /usr/lib/ISOLINUX/isolinux.bin
> > Using /usr/lib/syslinux/modules/bios/ldlinux.c32
> > Kernel: arch/x86/boot/image.iso is ready
> 
> The build process is using a ton of files and we don't list them. Maybe print them 
> when V=1, but not by default.
> 
> The only lines printed should be:
> 
> > Kernel: arch/x86/boot/bzImage is ready  (#75)
> >   GENIMAGE arch/x86/boot/image.iso
> 
> Users are totally not interested in the details. They want to see a single line of 
> output about which file is being built, but that's it.
>
I agree with you. So I will remove the 'Using ...', and 'set -x' if V=1.

> Thanks,
> 
> 	Ingo

-- 
Thanks,
Changbin Du

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]