From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754940AbdKINuS (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Nov 2017 08:50:18 -0500
Received: from mail-wr0-f195.google.com ([209.85.128.195]:47409 "EHLO
        mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754799AbdKINuO (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Nov 2017 08:50:14 -0500
X-Google-Smtp-Source: ABhQp+SDZwI1n1J3Z/0KuvEUvawINr1rLQck3fvFTWQ72aFEY0zrj4zZfKVBbqtOoGgCkRrBflMqLg==
Date: Thu, 9 Nov 2017 14:50:09 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
        "H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>,
        Borislav Petkov <bp@suse.de>, Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Brian Gerst <brgerst@gmail.com>, Chris Metcalf <cmetcalf@mellanox.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Masami Hiramatsu <mhiramat@kernel.org>, Huang Rui <ray.huang@amd.com>,
        Jiri Slaby <jslaby@suse.cz>, Jonathan Corbet <corbet@lwn.net>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Vlastimil Babka <vbabka@suse.cz>, Chen Yucong <slaoub@gmail.com>,
        "Ravi V. Shankar" <ravi.v.shankar@intel.com>,
        Shuah Khan <shuah@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        the arch/x86 maintainers <x86@kernel.org>, ricardo.neri@intel.com,
        Adam Buchbinder <adam.buchbinder@gmail.com>,
        Colin Ian King <colin.king@canonical.com>,
        Lorenzo Stoakes <lstoakes@gmail.com>,
        Qiaowei Ren <qiaowei.ren@intel.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Kees Cook <keescook@chromium.org>,
        Thomas Garnier <thgarnie@google.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH v10 13/18] x86/insn-eval: Add utility functions to get
 segment selector
Message-ID: <20171109135009.w2rnshuttqdx5h52@gmail.com>
References: <1509135945-13762-1-git-send-email-ricardo.neri-calderon@linux.intel.com>
 <1509135945-13762-14-git-send-email-ricardo.neri-calderon@linux.intel.com>
 <CAK8P3a3847vkZi1SpTkypX5HVJQS5h3twLU2RhAF48b_MaokOw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK8P3a3847vkZi1SpTkypX5HVJQS5h3twLU2RhAF48b_MaokOw@mail.gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Arnd Bergmann <arnd@arndb.de> wrote:

> On Fri, Oct 27, 2017 at 10:25 PM, Ricardo Neri
> <ricardo.neri-calderon@linux.intel.com> wrote:
> 
> > diff --git a/arch/x86/include/asm/inat.h b/arch/x86/include/asm/inat.h
> > index 02aff08..1c78580 100644
> > --- a/arch/x86/include/asm/inat.h
> > +++ b/arch/x86/include/asm/inat.h
> > @@ -97,6 +97,16 @@
> >  #define INAT_MAKE_GROUP(grp)   ((grp << INAT_GRP_OFFS) | INAT_MODRM)
> >  #define INAT_MAKE_IMM(imm)     (imm << INAT_IMM_OFFS)
> >
> > +/* Identifiers for segment registers */
> > +#define INAT_SEG_REG_IGNORE    0
> > +#define INAT_SEG_REG_DEFAULT   1
> > +#define INAT_SEG_REG_CS                2
> > +#define INAT_SEG_REG_SS                3
> > +#define INAT_SEG_REG_DS                4
> > +#define INAT_SEG_REG_ES                5
> > +#define INAT_SEG_REG_FS                6
> > +#define INAT_SEG_REG_GS                7
> > +
> 
> linux-next still reports a warning because of this change:
> 
> Warning: synced file at 'tools/objtool/arch/x86/include/asm/inat.h'
> differs from latest kernel version at 'arch/x86/include/asm/inat.h'
> 
> Should the same change be applied to the objtool file in the
> tip:x86/mpx branch?

No, the best flow is that the headers will be synced once both components are 
upstream.

This is an integration artifact - and we don't want to 'pre sync', because what 
happens if Linus has to reject the arch/x86/include/asm/inat.h changes for 
whatever reason, and the tooling changes go upstream first?

Thanks,

	Ingo