From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753927AbdKIQph (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Nov 2017 11:45:37 -0500
Received: from mx1.redhat.com ([209.132.183.28]:58574 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753500AbdKIQpe (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Nov 2017 11:45:34 -0500
Date: Thu, 9 Nov 2017 17:45:23 +0100
From: Radim Krcmar <rkrcmar@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Pankaj Gupta <pagupta@redhat.com>, Wanpeng Li <kernellwp@gmail.com>,
        Eduardo Valentin <eduval@amazon.com>,
        Paolo Bonzini <pbonzini@redhat.com>, Matt Wilson <msw@amazon.com>,
        Jonathan Corbet <corbet@lwn.net>, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        the arch/x86 maintainers <x86@kernel.org>,
        Waiman Long <longman@redhat.com>, kvm <kvm@vger.kernel.org>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        "Jan H . Schoenherr" <jschoenh@amazon.de>,
        Anthony Liguori <aliguori@amazon.com>
Subject: Re: [PATCHv3 1/1] locking/qspinlock/x86: Avoid test-and-set when
 PV_DEDICATED is set
Message-ID: <20171109164523.GF20859@flask>
References: <1509999980-10828-1-git-send-email-eduval@amazon.com>
 <CANRm+CxfYduv3qW7JNw9Li2V0DYbk5mZ0YL30Akh=eXHgaXigw@mail.gmail.com>
 <789734192.29237413.1510242805535.JavaMail.zimbra@redhat.com>
 <20171109160536.GE20859@flask>
 <20171109161701.y3eqqrvs5jpg46lr@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171109161701.y3eqqrvs5jpg46lr@hirez.programming.kicks-ass.net>
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 09 Nov 2017 16:45:34 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2017-11-09 17:17+0100, Peter Zijlstra:
> On Thu, Nov 09, 2017 at 05:05:36PM +0100, Radim Krcmar wrote:
> > 2017-11-09 10:53-0500, Pankaj Gupta:
> > > 2] PV TLB should also behave as per option PV_DEDICATED for better performance.
> > 
> > Right,
> 
> Shouldn't KVM do flush_tlb_other() in any case? Not sure how
> PV_DEDICATED can help with that.

It will, the suggestion was based on recent extension of the
flush_tlb_others implementaion, https://lkml.org/lkml/2017/11/8/1146.

PV_TLB_FLUSH allows a guest to set a flush bit instead of sending flush
IPI if the target VCPU is not running.  This would be a waste of time
with PV_DEDICATED as all VCPUs are expected to always running.

With PV_DEDICATED, the guest should keep using native_flush_tlb_others.