From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753773AbdKISeb (ORCPT ); Thu, 9 Nov 2017 13:34:31 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:58942 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752642AbdKISe2 (ORCPT ); Thu, 9 Nov 2017 13:34:28 -0500 Date: Thu, 9 Nov 2017 18:34:22 +0000 From: Al Viro To: Colin King Cc: Greg Kroah-Hartman , Marcus Wolf , devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: pi433: fix missing break in switch statement. Message-ID: <20171109183422.GA21978@ZenIV.linux.org.uk> References: <20171109171955.10911-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171109171955.10911-1-colin.king@canonical.com> User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 09, 2017 at 05:19:55PM +0000, Colin King wrote: > From: Colin Ian King > > The PI433_IOC_WR_RX_CFG case is missing a break and will fall through > to the default case and errorenously return -EINVAL. Fix this by > adding in missing break. Folded and pushed...