From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754690AbdKIVpo (ORCPT ); Thu, 9 Nov 2017 16:45:44 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:44602 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754562AbdKIVpm (ORCPT ); Thu, 9 Nov 2017 16:45:42 -0500 Date: Thu, 9 Nov 2017 22:45:40 +0100 From: Pavel Machek To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: sre@kernel.org, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com, clayton@craftyguy.net, martijn@brixit.nl, sakari.ailus@linux.intel.com, afd@ti.com, kernel@networkimprov.net, devicetree@vger.kernel.org, robh+dt@kernel.org Subject: Re: [PATCH] Add support for bq27521 battery monitor Message-ID: <20171109214540.GB23376@amd> References: <20171109210615.GA27638@amd> <20171109212945.2sgu56zkse7nbzo3@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IiVenqGWf+H9Y6IX" Content-Disposition: inline In-Reply-To: <20171109212945.2sgu56zkse7nbzo3@pali> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --IiVenqGWf+H9Y6IX Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu 2017-11-09 22:29:45, Pali Roh=E1r wrote: > On Thursday 09 November 2017 22:06:15 Pavel Machek wrote: > > diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/sup= ply/bq27xxx_battery.c > > index ed44439..ee2851a 100644 > > --- a/drivers/power/supply/bq27xxx_battery.c > > +++ b/drivers/power/supply/bq27xxx_battery.c > > @@ -381,6 +381,30 @@ static u8 bq27xxx_regs[][BQ27XXX_REG_MAX] =3D { > > [BQ27XXX_REG_AP] =3D INVALID_REG_ADDR, > > BQ27XXX_DM_REG_ROWS, > > }, > > + [BQ27521] =3D { /* FIXME */ > > + [BQ27XXX_REG_CTRL] =3D 0x02, > > + [BQ27XXX_REG_TEMP] =3D 0x0a, > > + [BQ27XXX_REG_INT_TEMP] =3D INVALID_REG_ADDR, > > + [BQ27XXX_REG_VOLT] =3D 0x0c, > > + [BQ27XXX_REG_AI] =3D 0x0e, > > + [BQ27XXX_REG_FLAGS] =3D 0x08, > > + [BQ27XXX_REG_TTE] =3D INVALID_REG_ADDR, > > + [BQ27XXX_REG_TTF] =3D INVALID_REG_ADDR, > > + [BQ27XXX_REG_TTES] =3D INVALID_REG_ADDR, > > + [BQ27XXX_REG_TTECP] =3D INVALID_REG_ADDR, > > + [BQ27XXX_REG_NAC] =3D INVALID_REG_ADDR, > > + [BQ27XXX_REG_FCC] =3D INVALID_REG_ADDR, > > + [BQ27XXX_REG_CYCT] =3D INVALID_REG_ADDR, > > + [BQ27XXX_REG_AE] =3D INVALID_REG_ADDR, > > + [BQ27XXX_REG_SOC] =3D INVALID_REG_ADDR, > > + [BQ27XXX_REG_DCAP] =3D INVALID_REG_ADDR, > > + [BQ27XXX_REG_AP] =3D INVALID_REG_ADDR, > > + [BQ27XXX_DM_CTRL] =3D INVALID_REG_ADDR, > > + [BQ27XXX_DM_CLASS] =3D INVALID_REG_ADDR, > > + [BQ27XXX_DM_BLOCK] =3D INVALID_REG_ADDR, > > + [BQ27XXX_DM_DATA] =3D INVALID_REG_ADDR, > > + [BQ27XXX_DM_CKSUM] =3D INVALID_REG_ADDR, > > + }, > > [BQ27530] =3D { > > [BQ27XXX_REG_CTRL] =3D 0x00, > > [BQ27XXX_REG_TEMP] =3D 0x06, >=20 > Hi! IIRC those registers are valid only for sn27521 chip in revision 14 > (or new). For older revision is used different register map. And > detection of chip revision is somehow possible via some registers. Yes, I know.. I even had this, but as I can't test it, and early N950 samples should be very very rare, I'd prefer the patch as is. @@ -1905,6 +1940,23 @@ int bq27xxx_battery_setup(struct bq27xxx_device_info= *di) =20 dev_info(di->dev, "support ver. %s enabled\n", DRIVER_VERSION); =20 + if (di->chip =3D=3D BQ27521) { + int val; + val =3D di->bus.read(di, 0x32, false); + if (val =3D=3D 0x2100) { + printk("rev. 13 chip detected; add support\n"); + /* https://elinux.org/N950 has details */ + return PTR_ERR(ENODEV); + } + + val =3D di->bus.read(di, 0x34, false); + if ((val & 0xff00) !=3D 0x2100) { + printk("rev. 14 chip not detected?!\n"); + return PTR_ERR(EINVAL); + } + printk("verified chip rev. 14\n"); + } + bq27xxx_battery_settings(di); bq27xxx_battery_update(di); =20 --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --IiVenqGWf+H9Y6IX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAloEzIQACgkQMOfwapXb+vIF1ACePywsr0HPpSouo7JlVuc5ncVo gtoAnR31A63h5i+bKEvX0pJrenGzGjjc =aMzX -----END PGP SIGNATURE----- --IiVenqGWf+H9Y6IX--