From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
"chanwoo@kernel.org" <chanwoo@kernel.org>,
Inki Dae <inki.dae@samsung.com>,
lkml <linux-kernel@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
Vinayak Holikatti <vinholikatti@gmail.com>,
Vivek Gautam <vivek.gautam@codeaurora.org>
Subject: Re: [PATCH v5 0/7] PM / devfreq: Use OPP interface to handle the frequency
Date: Thu, 9 Nov 2017 16:12:59 -0800 [thread overview]
Message-ID: <20171110001259.GD28761@minitux> (raw)
In-Reply-To: <20171109235654epcms1p29b8d05dce899f1b11919823ed66cbd1c@epcms1p2>
On Thu 09 Nov 15:56 PST 2017, MyungJoo Ham wrote:
> > On Sun, Oct 22, 2017 at 6:32 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> > > These patches makes the devfreq to use the OPP interface and clean-up codes.
> > >
> >
> > Hi Chanwoo,
> >
> > This patch series breaks UFS support on modern Qualcomm platforms
> > (e.g. MSM8996).
>
> Could you please show us the code location of it?
>
The driver is drivers/scsi/ufs/ufshcd.c function ufshcd_probe_hba()
calls devm_devfreq_add_device() without there being an opp table
associated with hba->dev. This used to return fine and
ufshcd_devfreq_target() was called with *freq = UINT_MAX.
Unfortunately the driver seems to be designed in such a way that without
a call to ufshcd_devfreq_target() with *freq 0 or UINT_MAX some clock is
left off, causing my board to reboot; so there's unfortunately a few
levels of issues to fix here.
Regards,
Bjorn
prev parent reply other threads:[~2017-11-10 0:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171023013213epcas1p165faa416f69659b60ec4c3f18ea251d8@epcas1p1.samsung.com>
2017-10-23 1:32 ` [PATCH v5 0/7] PM / devfreq: Use OPP interface to handle the frequency Chanwoo Choi
2017-10-23 1:32 ` [PATCH v5 1/7] PM / devfreq: Set min/max_freq when adding the devfreq device Chanwoo Choi
2017-10-23 1:32 ` [PATCH v5 2/7] Revert "PM / devfreq: Add show_one macro to delete the duplicate code" Chanwoo Choi
2017-10-23 1:32 ` [PATCH v5 3/7] PM / devfreq: Use the available min/max frequency Chanwoo Choi
2017-10-23 5:10 ` MyungJoo Ham
2017-10-23 1:32 ` [PATCH v5 4/7] PM / devfreq: Change return type of devfreq_set_freq_table() Chanwoo Choi
2017-10-23 1:32 ` [PATCH v5 5/7] PM / devfreq: Show the all available frequencies Chanwoo Choi
2017-10-23 1:32 ` [PATCH v5 6/7] PM / devfreq: Remove unneeded conditional statement Chanwoo Choi
2017-10-23 1:32 ` [PATCH v5 7/7] PM / devfreq: Define the constant governor name Chanwoo Choi
2017-11-06 18:11 ` [PATCH v5 0/7] PM / devfreq: Use OPP interface to handle the frequency Bjorn Andersson
2017-11-09 23:56 ` MyungJoo Ham
2017-11-10 0:12 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110001259.GD28761@minitux \
--to=bjorn.andersson@linaro.org \
--cc=chanwoo@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=inki.dae@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rafael.j.wysocki@intel.com \
--cc=vinholikatti@gmail.com \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox