From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756041AbdKJE7D (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Nov 2017 23:59:03 -0500
Received: from mga05.intel.com ([192.55.52.43]:42206 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755924AbdKJE7C (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Nov 2017 23:59:02 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.44,372,1505804400"; 
   d="scan'208";a="174195937"
Date: Fri, 10 Nov 2017 10:32:14 +0530
From: Vinod Koul <vinod.koul@intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        ALSA <alsa-devel@alsa-project.org>, Mark <broonie@kernel.org>,
        Takashi <tiwai@suse.de>, Pierre <pierre-louis.bossart@linux.intel.com>,
        Sanyog Kale <sanyog.r.kale@intel.com>,
        Shreyas NC <shreyas.nc@intel.com>, patches.audio@intel.com,
        alan@linux.intel.com, Charles Keepax <ckeepax@opensource.cirrus.com>,
        Sagar Dharia <sdharia@codeaurora.org>, plai@codeaurora.org,
        Sudheer Papothi <spapothi@codeaurora.org>
Subject: Re: [PATCH 03/14] soundwire: Add Master registration
Message-ID: <20171110050214.GM3187@localhost>
References: <1508382211-3154-1-git-send-email-vinod.koul@intel.com>
 <1508382211-3154-4-git-send-email-vinod.koul@intel.com>
 <a44f40ab-bd8b-f778-6819-73ae151c97ab@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a44f40ab-bd8b-f778-6819-73ae151c97ab@linaro.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 09, 2017 at 09:14:16PM +0000, Srinivas Kandagatla wrote:
> 
> 
> On 19/10/17 04:03, Vinod Koul wrote:
> 
> >+/**
> >+ * sdw_add_bus_master: add a bus Master instance
> >+ *
> >+ * @bus: bus instance
> >+ *
> >+ * Initializes the bus instance, read properties and create child
> >+ * devices.
> >+ */
> 
> Some of the exported functions are missing kerneldocs.
> Is it something you plan to add in next version of the patcheset?

I though most were, will double check to be sure.

> 
> >+int sdw_add_bus_master(struct sdw_bus *bus)
> >+{
> >+	int ret;
> >+
> >+	if (!bus->dev) {
> >+		pr_err("SoundWire bus has no device");
> >+		return -ENODEV;
> >+	}
> >+
> >+	mutex_init(&bus->bus_lock);
> >+	INIT_LIST_HEAD(&bus->slaves);
> >+
> >+	/*
> >+	 * SDW is an enumerable bus, but devices can be powered off. So,
> >+	 * they won't be able to report as present.
> >+	 *
> >+	 * Create Slave devices based on Slaves described in
> >+	 * the respective firmware (ACPI/DT)
> >+	 */
> >+
> >+	if (IS_ENABLED(CONFIG_ACPI) && bus->dev && ACPI_HANDLE(bus->dev))
> >+		ret = sdw_acpi_find_slaves(bus);
> >+	else if (IS_ENABLED(CONFIG_OF) && bus->dev && bus->dev->of_node)
> >+		ret = sdw_of_find_slaves(bus);
> >+	else
> bus->dev is already checked in the start of the function, do we need to
> check once again ?

yes already fixed, thanks

-- 
~Vinod