From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754859AbdKKBpj (ORCPT ); Fri, 10 Nov 2017 20:45:39 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:60414 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbdKKBpi (ORCPT ); Fri, 10 Nov 2017 20:45:38 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 32F9F60600 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org From: Stephen Boyd To: Rob Herring , Frank Rowand Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org Subject: [PATCH] of: Document exactly what of_find_node_by_name() puts Date: Fri, 10 Nov 2017 17:45:36 -0800 Message-Id: <20171111014536.3592-1-sboyd@codeaurora.org> X-Mailer: git-send-email 2.15.0.124.g7668cbc60578 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It isn't clear if this function of_node_put()s the 'from' argument, or the node it finds in the search. Clearly indicate which variable is touched. Signed-off-by: Stephen Boyd --- drivers/of/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index 63897531cd75..602c5d65734a 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -866,7 +866,7 @@ EXPORT_SYMBOL(of_find_node_opts_by_path); * @from: The node to start searching from or NULL, the node * you pass will not be searched, only the next one * will; typically, you pass what the previous call - * returned. of_node_put() will be called on it + * returned. of_node_put() will be called on @from. * @name: The name string to match against * * Returns a node pointer with refcount incremented, use -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project