From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752219AbdKKWMN (ORCPT ); Sat, 11 Nov 2017 17:12:13 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:54572 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751651AbdKKWMM (ORCPT ); Sat, 11 Nov 2017 17:12:12 -0500 X-Google-Smtp-Source: AGs4zMb/uM/XqDQRuXJhig3MfIgt6Mx/BoI63bLxTBoJbCPPnbYijxIRaoB1UA6G6IV3yi+Gv7K6qQ== Date: Sat, 11 Nov 2017 23:12:07 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Darren Hart Cc: Matthew Garrett , Andy Shevchenko , "Gabriel M. Elder" , Gabriele Mazzotta , Mario.Limonciello@dell.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] dell-laptop: Fix keyboard led max_brightness property for Dell Latitude E6410 Message-ID: <20171111221207.njayezgw36o7mwle@pali> References: <1508349961-15051-1-git-send-email-pali.rohar@gmail.com> <1509654324-709-1-git-send-email-pali.rohar@gmail.com> <20171103011843.GF7971@fury> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171103011843.GF7971@fury> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 02 November 2017 18:18:43 Darren Hart wrote: > On Thu, Nov 02, 2017 at 09:25:24PM +0100, Pali Rohár wrote: > > This machine reports number of keyboard backlight led levels, instead of > > value of the last led level index. Therefore max_brightness properly needs > > to be subtracted by 1 to match led max_brightness API. > > > > Signed-off-by: Pali Rohár > > Reported-by: Gabriel M. Elder > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=196913 > > --- > > Changes since v2: > > * Rename quirk entry to kbd_led_levels_off_1 > > Changes since v1: > > * Update kbd_info.levels at initialization time based on quirk > > --- > > drivers/platform/x86/dell-laptop.c | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c > > index f42159f..7424e53 100644 > > --- a/drivers/platform/x86/dell-laptop.c > > +++ b/drivers/platform/x86/dell-laptop.c > > @@ -49,6 +49,7 @@ > > > > struct quirk_entry { > > u8 touchpad_led; > > + u8 kbd_led_levels_off_1; > > I believe you and Andy agreed to use a boolean type here? I'm going to fix this and other entries to boolean type in another patch. -- Pali Rohár pali.rohar@gmail.com