From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751697AbdKLGlv (ORCPT ); Sun, 12 Nov 2017 01:41:51 -0500 Received: from mga14.intel.com ([192.55.52.115]:38919 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750855AbdKLGlu (ORCPT ); Sun, 12 Nov 2017 01:41:50 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,382,1505804400"; d="scan'208";a="592772" Date: Sat, 11 Nov 2017 22:41:48 -0800 From: Andi Kleen To: Guenter Roeck Cc: Andi Kleen , x86@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org Subject: Re: [v8, 4/5] x86/xsave: Make XSAVE check the base CPUID features before enabling Message-ID: <20171112064148.GL8522@tassilo.jf.intel.com> References: <20171005215256.25659-5-andi@firstfloor.org> <20171111231521.GA31139@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171111231521.GA31139@roeck-us.net> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > this patch makes qemu spit out the following warning, possibly because > it doesn't support all expected CPUID features for the various CPUs. > > WARNING: CPU: 0 PID: 0 at arch/x86/kernel/fpu/xstate.c:614 > fpu__init_system_xstate+0x403/0x721 > > with associated traceback. > > I understand that this is a qemu problem, but does the traceback really > add value ? I agree it could be removed. -Andi