From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751346AbdKLS3f (ORCPT <rfc822;w@1wt.eu>);
        Sun, 12 Nov 2017 13:29:35 -0500
Received: from vps0.lunn.ch ([185.16.172.187]:53090 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751202AbdKLS3b (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 12 Nov 2017 13:29:31 -0500
Date: Sun, 12 Nov 2017 19:29:21 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Pan Bian <bianpan2016@163.com>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
        Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] net: dsa: lan9303: correctly check return value of
 devm_gpiod_get_optional
Message-ID: <20171112182921.GI30830@lunn.ch>
References: <1510501089-9451-1-git-send-email-bianpan2016@163.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1510501089-9451-1-git-send-email-bianpan2016@163.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Nov 12, 2017 at 11:38:09PM +0800, Pan Bian wrote:
> Function devm_gpiod_get_optional() returns an ERR_PTR on failure. Its
> return value should not be validated by a NULL check. Instead, use IS_ERR.
> 
> Signed-off-by: Pan Bian <bianpan2016@163.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew