From: Tejun Heo <tj@kernel.org>
To: axboe@kernel.dk
Cc: shli@kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com, lizefan@huawei.com, hannes@cmpxchg.org,
cgroups@vger.kernel.org, guro@fb.com, Tejun Heo <tj@kernel.org>
Subject: [PATCH 3/7] blkcg: associate a request with its blkcg_gq instead of request_list
Date: Sun, 12 Nov 2017 14:26:09 -0800 [thread overview]
Message-ID: <20171112222613.3613362-4-tj@kernel.org> (raw)
In-Reply-To: <20171112222613.3613362-1-tj@kernel.org>
On the legacy request_queue, each blkcg_gq has a dedicated
request_list that requests for the cgroup are allocated from. Each
request points to the originating request_list and cgroup membership
can be determined by examining which cgroup the associated
request_list belongs to.
This doesn't work for blk-mq which doesn't use request_list. Let's
associate each request with the blkcg_gq directly. Except for minor
wrapper changes, this doesn't affect the legacy request_queue and will
allow blk-mq to track each request's cgroup association.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
block/blk-mq.c | 2 +-
include/linux/blk-cgroup.h | 9 ++++++---
include/linux/blkdev.h | 2 +-
3 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 98a1860..af958c4 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -306,7 +306,7 @@ static struct request *blk_mq_rq_ctx_init(struct blk_mq_alloc_data *data,
rq->part = NULL;
rq->start_time = jiffies;
#ifdef CONFIG_BLK_CGROUP
- rq->rl = NULL;
+ rq->blkg = NULL;
set_start_time_ns(rq);
rq->io_start_time_ns = 0;
#endif
diff --git a/include/linux/blk-cgroup.h b/include/linux/blk-cgroup.h
index c0d4736..b5721d32 100644
--- a/include/linux/blk-cgroup.h
+++ b/include/linux/blk-cgroup.h
@@ -463,7 +463,7 @@ static inline void blk_put_rl(struct request_list *rl)
*/
static inline void blk_rq_set_rl(struct request *rq, struct request_list *rl)
{
- rq->rl = rl;
+ rq->blkg = rl->blkg;
}
/**
@@ -474,7 +474,10 @@ static inline void blk_rq_set_rl(struct request *rq, struct request_list *rl)
*/
static inline struct request_list *blk_rq_rl(struct request *rq)
{
- return rq->rl;
+ if (!rq->blkg->parent)
+ return &rq->q->root_rl;
+ else
+ return &rq->blkg->rl;
}
struct request_list *__blk_queue_next_rl(struct request_list *rl,
@@ -762,7 +765,7 @@ static inline void blkg_put(struct blkcg_gq *blkg) { }
static inline struct request_list *blk_get_rl(struct request_queue *q,
struct bio *bio) { return &q->root_rl; }
static inline void blk_put_rl(struct request_list *rl) { }
-static inline void blk_rq_set_rl(struct request *rq, struct request_list *rl) { }
+static inline void blk_rq_set_blkg(struct request *rq, struct blkcg_gq *blkg) { }
static inline struct request_list *blk_rq_rl(struct request *rq) { return &rq->q->root_rl; }
static inline bool blkcg_bio_issue_check(struct request_queue *q,
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 8da6637..6ec1067 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -206,7 +206,7 @@ struct request {
unsigned long start_time;
struct blk_issue_stat issue_stat;
#ifdef CONFIG_BLK_CGROUP
- struct request_list *rl; /* rl this rq is alloced from */
+ struct blkcg_gq *blkg; /* blkg of this rq */
unsigned long long start_time_ns;
unsigned long long io_start_time_ns; /* when passed to hardware */
#endif
--
2.9.5
next prev parent reply other threads:[~2017-11-12 22:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-12 22:26 [PATCHSET] blkcg: basic accounting and throttling fixes Tejun Heo
2017-11-12 22:26 ` [PATCH 1/7] blkcg: relocate __blkg_release_rcu() Tejun Heo
2017-11-14 23:12 ` Shaohua Li
2017-11-12 22:26 ` [PATCH 2/7] blkcg: use percpu_ref for blkcg_gq->refcnt Tejun Heo
2017-11-14 23:12 ` Shaohua Li
2017-11-12 22:26 ` Tejun Heo [this message]
2017-11-13 20:15 ` [PATCH v2 3/7] blkcg: associate a request with its blkcg_gq instead of request_list Tejun Heo
2017-11-14 23:17 ` Shaohua Li
2017-11-15 17:11 ` Tejun Heo
2017-11-12 22:26 ` [PATCH 4/7] blkcg: refactor blkcg_gq lookup and creation in blkcg_bio_issue_check() Tejun Heo
2017-11-14 23:18 ` Shaohua Li
2017-11-12 22:26 ` [PATCH 5/7] blkcg: associate blk-mq requests with the matching blkcg_gqs Tejun Heo
2017-11-12 22:26 ` [PATCH 6/7] blkcg: account requests instead of bios for request based request_queues Tejun Heo
2017-11-14 23:23 ` Shaohua Li
2017-11-15 17:18 ` [PATCH v2 " Tejun Heo
2017-11-15 17:19 ` [PATCH " Jens Axboe
2017-11-15 17:22 ` [PATCH v3 " Tejun Heo
2017-11-12 22:26 ` [PATCH 7/7] blk-throtl: don't throttle the same IO multiple times Tejun Heo
2017-11-13 4:07 ` Shaohua Li
2017-11-13 11:13 ` Tejun Heo
2017-11-13 15:57 ` Tejun Heo
2017-11-13 19:54 ` Shaohua Li
2017-11-13 19:58 ` Tejun Heo
2017-11-13 19:58 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171112222613.3613362-4-tj@kernel.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox