From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v1 2/5] perf, tools: Save event scaling factors in perf.data
Date: Mon, 13 Nov 2017 10:02:37 +0100 [thread overview]
Message-ID: <20171113090237.GB21325@krava> (raw)
In-Reply-To: <20171109145528.23371-3-andi@firstfloor.org>
On Thu, Nov 09, 2017 at 06:55:25AM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> To process metrics, perf script needs to know the scaling
> factors reported by sysfs for events. Save the scaling factors
> in the perf.data metadata in a new SCALE header.
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
there's event_update event for scale and some other evsel stuff
that was before we were able to put header through pipe
it might be less code changes.. sythesize it via:
if (has_scale(counter)) {
err = perf_event__synthesize_event_update_scale(NULL, counter, process_synthesized_event);
if (err < 0) {
pr_err("Couldn't synthesize evsel scale.\n");
return err;
}
}
and new tool's event_update callback, which is already implemented
in perf_event__process_event_update
having event instead of header feature might have
other drawbacks.. not sure it will fit here
jirka
next prev parent reply other threads:[~2017-11-13 9:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 14:55 Add fine grained sampled metrics for perf script Andi Kleen
2017-11-09 14:55 ` [PATCH v1 1/5] perf, tools: Document some missing perf.data headers Andi Kleen
2017-11-13 8:54 ` Jiri Olsa
2017-11-13 18:23 ` Arnaldo Carvalho de Melo
2017-11-18 8:28 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-11-09 14:55 ` [PATCH v1 2/5] perf, tools: Save event scaling factors in perf.data Andi Kleen
2017-11-13 9:02 ` Jiri Olsa [this message]
2017-11-09 14:55 ` [PATCH v1 3/5] perf, tools, script: Allow printing period for non freq mode groups Andi Kleen
2017-11-13 9:11 ` Jiri Olsa
2017-11-13 18:23 ` Arnaldo Carvalho de Melo
2017-11-18 8:29 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-11-09 14:55 ` [PATCH v1 4/5] perf, tools: Add fallback in perf_evsel__nr_cpus for no map Andi Kleen
2017-11-13 9:22 ` Jiri Olsa
2017-11-14 5:03 ` Andi Kleen
2017-11-09 14:55 ` [PATCH v1 5/5] perf, tools, script: Allow computing metrics in perf script Andi Kleen
2017-11-13 9:30 ` Jiri Olsa
2017-11-13 18:23 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171113090237.GB21325@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox