From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752256AbdKMJMD (ORCPT <rfc822;w@1wt.eu>);
        Mon, 13 Nov 2017 04:12:03 -0500
Received: from mx1.redhat.com ([209.132.183.28]:51822 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751861AbdKMJMA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 13 Nov 2017 04:12:00 -0500
Date: Mon, 13 Nov 2017 10:11:58 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v1 3/5] perf, tools, script: Allow printing period for
 non freq mode groups
Message-ID: <20171113091158.GC21325@krava>
References: <20171109145528.23371-1-andi@firstfloor.org>
 <20171109145528.23371-4-andi@firstfloor.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171109145528.23371-4-andi@firstfloor.org>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 13 Nov 2017 09:12:00 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 09, 2017 at 06:55:26AM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> When using leader sampling the values of the not sampled but counted
> events are shown by perf script in "period".
> 
> Currently printing period is only allowed when the main event
> has a period, that is it is in frequency mode.
> 
> This implies that we cannot dump the values of counted events
> when the leader event is not in frequency mode.
> 
> Just remove the check that the period must be set on all
> events. It will just be printed as 0 instead if it's not
> available.

it'll be the value of configured period, not 0

int perf_evsel__parse_sample(struct ...
  ...
  data->period = evsel->attr.sample_period;

  $ perf record -c 100000 
  $ perf script -F event,period | head -3
  Failed to open /tmp/perf-2048.map, continuing without symbols
      100000 cycles:ppp: 
      100000 cycles:ppp: 


other than that I think we can remove that check,
because we will have always sane number in period

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka