From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751249AbdKMJWd (ORCPT ); Mon, 13 Nov 2017 04:22:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51653 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbdKMJWc (ORCPT ); Mon, 13 Nov 2017 04:22:32 -0500 Date: Mon, 13 Nov 2017 10:22:30 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH v1 4/5] perf, tools: Add fallback in perf_evsel__nr_cpus for no map Message-ID: <20171113092230.GD21325@krava> References: <20171109145528.23371-1-andi@firstfloor.org> <20171109145528.23371-5-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171109145528.23371-5-andi@firstfloor.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 13 Nov 2017 09:22:32 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 09, 2017 at 06:55:27AM -0800, Andi Kleen wrote: > From: Andi Kleen > > Support the case of the event having no cpumap in perf_evsel__nr_cpus. > Just return 1 in this case. This can happen in perf script > when it uses the perf stat shadow functions. why 1, where in shadow code? you can synthesize cpus for event via event_update event jirka > > Signed-off-by: Andi Kleen > --- > tools/perf/util/evsel.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h > index db658785d828..25f21cde8826 100644 > --- a/tools/perf/util/evsel.h > +++ b/tools/perf/util/evsel.h > @@ -157,7 +157,8 @@ static inline struct cpu_map *perf_evsel__cpus(struct perf_evsel *evsel) > > static inline int perf_evsel__nr_cpus(struct perf_evsel *evsel) > { > - return perf_evsel__cpus(evsel)->nr; > + struct cpu_map *map = perf_evsel__cpus(evsel); > + return map ? map->nr : 1; > } > > void perf_counts_values__scale(struct perf_counts_values *count, > -- > 2.13.6 >