From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752761AbdKMLwt (ORCPT ); Mon, 13 Nov 2017 06:52:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50140 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752493AbdKMLws (ORCPT ); Mon, 13 Nov 2017 06:52:48 -0500 Date: Mon, 13 Nov 2017 12:52:45 +0100 From: Jiri Olsa To: Stephane Eranian Cc: linux-kernel@vger.kernel.org, acme@redhat.com, peterz@infradead.org, mingo@elte.hu, ak@linux.intel.com, kan.liang@intel.com Subject: Re: [PATCH v4 5/5] perf/script: add support for PERF_SAMPLE_SKID_IP Message-ID: <20171113115245.GD3017@krava> References: <1510214233-2074-1-git-send-email-eranian@google.com> <1510214233-2074-6-git-send-email-eranian@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1510214233-2074-6-git-send-email-eranian@google.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 13 Nov 2017 11:52:48 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 08, 2017 at 11:57:13PM -0800, Stephane Eranian wrote: > This patch adds a skid_ip field to perf script > to dump the raw value of the PERF_SAMPLE_SKID_IP > field in each sample. > > $ perf script -F +ip,+skid_ip ...... > > The field is not enabled by default. > > Signed-off-by: Stephane Eranian > --- > tools/perf/Documentation/perf-script.txt | 2 +- > tools/perf/builtin-script.c | 10 ++++++++-- > 2 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/Documentation/perf-script.txt b/tools/perf/Documentation/perf-script.txt > index 2811fcf684cb..96871bd3a576 100644 > --- a/tools/perf/Documentation/perf-script.txt > +++ b/tools/perf/Documentation/perf-script.txt > @@ -117,7 +117,7 @@ OPTIONS > Comma separated list of fields to print. Options are: > comm, tid, pid, time, cpu, event, trace, ip, sym, dso, addr, symoff, > srcline, period, iregs, uregs, brstack, brstacksym, flags, bpf-output, brstackinsn, > - brstackoff, callindent, insn, insnlen, synth, phys_addr. > + brstackoff, callindent, insn, insnlen, synth, phys_addr, skid_ip. while we are at it, could we keep it the same as the field name in perf record? I dont mind using '-' or '_', just please keep it same other then that it looks ok, for patchset: Acked-by: Jiri Olsa thanks, jirka