From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753957AbdKMQw0 (ORCPT ); Mon, 13 Nov 2017 11:52:26 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:57869 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753752AbdKMQwZ (ORCPT ); Mon, 13 Nov 2017 11:52:25 -0500 From: Arnd Bergmann To: Linus Torvalds Cc: Arnd Bergmann , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: [PATCH 2/2] /proc/module: fix building without kallsyms Date: Mon, 13 Nov 2017 17:51:00 +0100 Message-Id: <20171113165146.2287420-2-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20171113165146.2287420-1-arnd@arndb.de> References: <20171113165146.2287420-1-arnd@arndb.de> X-Provags-ID: V03:K0:xgWOflf4vguySSloPJH6LKzYbLSs7EUr1piFKbqh8OhtXRlX6pY Coeyh+a3x8W+gmDCqV2PKGNkEZSwPo4vKIlrbbRwhFc8lS21zuCk42gtpCaUEyQLjuM3CuN Oii7H5/mhSuaEYkbtsKcdvz4sQfzdkOsiyKEFRF7SDzpAV/W3l3l6IA49knWrMMy9o9Rw0X Vvy6pRFYy8W7nYBrdKqXw== X-UI-Out-Filterresults: notjunk:1;V01:K0:m7//pRXGoTE=:6eOiRy8xP+qtWde/4SCPIo hspUQbVQWqmMSrMk560FZO0zR1jG3oBc1m50RxUCnJCbplQnmfwaLHpqUGPsjTj90w2D0hLe3 NWAKZpxttvRfswdCNOMINaQAwXU4AlpB0V8WR8S+dZTIpRPCFZ4+DhKaPUwdVh7OYPk/hZhJ7 CpFDNqtFV/wno95fkrygiYNmTFENSlpIH4aV8b7lsCm5D0lmtPQEAMIQ4KlyvI0XC37kCB6k+ MiEYRclonmjhhlCv/4lkZ9sW062+JPar02PGbzzZ23w/0imHUC6ctCEaiJQ3XiAyf0ZNepdNw qWJscGko7191N55Ppr5wnaTCDxFOaea2UcxuSQq57SlvEbqc77NqAwN2AGGS45caU8IBlKWyp /gTuIAgOvMGGLkO3/jf3g65KmfQbOx+nxaWaj3ENJYKe/Et527qiG7Fnn58WuIoJCYz6Htj7b UXMAOYh7KM1ubYZYU58vFBwkLVOh8b7OJ4GSEklYc2L5udb9ikIna19O1ovEP7eB4GcJdvDHm GV2HSubSa32/dtxzlQrThvIZUvbBq2In5HTYino3eO7GFtbTQ19Q55KVyobZR7o28Vgzpn0JA j4RB7t+H9t0nw5UlM/AevfCoRAtz8dydSXJvPR0Nuc/UvPfwpEPTX9YG8SAHIfH6tviulkuFL QxSjXeFrE9HmCwIDgJVasH/mfKmOOOQuin5wA9yxGSK9UDbl301ypkEvX93oTptucS0wI8D/6 Zcwl8frVeiWfaG/8FNmFMofXzX7kBbSODtxHJw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As reported by kernelci and other build bots, we now get a link failure without CONFIG_KALLSYMS: module.c:(.text+0xf2c): undefined reference to `kallsyms_show_value' This adds a dummy helper with the same name that can be used for compilation. It's not entirely clear to me what this should return for !CONFIG_KALLSYMS, I picked an unconditional 'false', which leads to the module address being unavailable to user space. Link: https://kernelci.org/build/mainline/branch/master/kernel/v4.14-5-g516fb7f2e73d/ Fixes: 516fb7f2e73d ("/proc/module: use the same logic as /proc/kallsyms for address exposure") Signed-off-by: Arnd Bergmann --- include/linux/kallsyms.h | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/include/linux/kallsyms.h b/include/linux/kallsyms.h index 0a777c5216b1..708f337d780b 100644 --- a/include/linux/kallsyms.h +++ b/include/linux/kallsyms.h @@ -14,8 +14,6 @@ #define KSYM_SYMBOL_LEN (sizeof("%s+%#lx/%#lx [%s]") + (KSYM_NAME_LEN - 1) + \ 2*(BITS_PER_LONG*3/10) + (MODULE_NAME_LEN - 1) + 1) -/* How and when do we show kallsyms values? */ -extern int kallsyms_show_value(void); #ifndef CONFIG_64BIT # define KALLSYM_FMT "%08lx" #else @@ -54,6 +52,9 @@ extern void __print_symbol(const char *fmt, unsigned long address); int lookup_symbol_name(unsigned long addr, char *symname); int lookup_symbol_attrs(unsigned long addr, unsigned long *size, unsigned long *offset, char *modname, char *name); +/* How and when do we show kallsyms values? */ +extern int kallsyms_show_value(void); + #else /* !CONFIG_KALLSYMS */ static inline unsigned long kallsyms_lookup_name(const char *name) @@ -112,6 +113,11 @@ static inline int lookup_symbol_attrs(unsigned long addr, unsigned long *size, u return -ERANGE; } +static inline int kallsyms_show_value(void) +{ + return false; +} + /* Stupid that this does nothing, but I didn't create this mess. */ #define __print_symbol(fmt, addr) #endif /*CONFIG_KALLSYMS*/ -- 2.9.0