From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754168AbdKMSXV (ORCPT ); Mon, 13 Nov 2017 13:23:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:53168 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752717AbdKMSXP (ORCPT ); Mon, 13 Nov 2017 13:23:15 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3ABFB21910 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Mon, 13 Nov 2017 15:23:11 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Andi Kleen , jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH v1 5/5] perf, tools, script: Allow computing metrics in perf script Message-ID: <20171113182311.GA4123@kernel.org> References: <20171109145528.23371-1-andi@firstfloor.org> <20171109145528.23371-6-andi@firstfloor.org> <20171113093011.GA22209@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171113093011.GA22209@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Nov 13, 2017 at 10:30:11AM +0100, Jiri Olsa escreveu: > On Thu, Nov 09, 2017 at 06:55:28AM -0800, Andi Kleen wrote: > > SNIP > > > static void process_event(struct perf_script *script, > > struct perf_sample *sample, struct perf_evsel *evsel, > > struct addr_location *al, > > @@ -1481,6 +1560,9 @@ static void process_event(struct perf_script *script, > > if (PRINT_FIELD(PHYS_ADDR)) > > printf("%16" PRIx64, sample->phys_addr); > > printf("\n"); > > + > > + if (PRINT_FIELD(METRIC)) > > + print_metric(script, thread, evsel, sample); > > } > > > > static struct scripting_ops *scripting_ops; > > diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h > > index 25f21cde8826..27a72b883645 100644 > > --- a/tools/perf/util/evsel.h > > +++ b/tools/perf/util/evsel.h > > @@ -108,6 +108,8 @@ struct perf_evsel { > > struct cpu_map *cpus; > > struct cpu_map *own_cpus; > > struct thread_map *threads; > > + u64 val; > > + int gnum; > > please put this to the priv (struct perf_stat_evsel) > with some comments that it's used in script only > > also there's per event dump feature that uses evsel->priv > (please rebase to latest Arnaldo's perf/core) in script, > so make sure you are mutualy exclusive No need, priv is supposed to be used by one tool only, i.e. its a too private area, that perf_evsel_stats thing started to be used by multiple tools, so I moved it to perf_evsel->stats and made perf_evsel->priv be a tool priv area again. I.e. move the above values to perf_stat_evsel and access it via evsel->stats. - Arnaldo > thanks, > jirka