From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v1 3/5] perf, tools, script: Allow printing period for non freq mode groups
Date: Mon, 13 Nov 2017 15:23:46 -0300 [thread overview]
Message-ID: <20171113182346.GC4123@kernel.org> (raw)
In-Reply-To: <20171113091158.GC21325@krava>
Em Mon, Nov 13, 2017 at 10:11:58AM +0100, Jiri Olsa escreveu:
> On Thu, Nov 09, 2017 at 06:55:26AM -0800, Andi Kleen wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > When using leader sampling the values of the not sampled but counted
> > events are shown by perf script in "period".
> >
> > Currently printing period is only allowed when the main event
> > has a period, that is it is in frequency mode.
> >
> > This implies that we cannot dump the values of counted events
> > when the leader event is not in frequency mode.
> >
> > Just remove the check that the period must be set on all
> > events. It will just be printed as 0 instead if it's not
> > available.
>
> it'll be the value of configured period, not 0
>
> int perf_evsel__parse_sample(struct ...
> ...
> data->period = evsel->attr.sample_period;
>
> $ perf record -c 100000
> $ perf script -F event,period | head -3
> Failed to open /tmp/perf-2048.map, continuing without symbols
> 100000 cycles:ppp:
> 100000 cycles:ppp:
>
>
> other than that I think we can remove that check,
> because we will have always sane number in period
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
Applied, after adding your comments.
- Arnaldo
next prev parent reply other threads:[~2017-11-13 18:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 14:55 Add fine grained sampled metrics for perf script Andi Kleen
2017-11-09 14:55 ` [PATCH v1 1/5] perf, tools: Document some missing perf.data headers Andi Kleen
2017-11-13 8:54 ` Jiri Olsa
2017-11-13 18:23 ` Arnaldo Carvalho de Melo
2017-11-18 8:28 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-11-09 14:55 ` [PATCH v1 2/5] perf, tools: Save event scaling factors in perf.data Andi Kleen
2017-11-13 9:02 ` Jiri Olsa
2017-11-09 14:55 ` [PATCH v1 3/5] perf, tools, script: Allow printing period for non freq mode groups Andi Kleen
2017-11-13 9:11 ` Jiri Olsa
2017-11-13 18:23 ` Arnaldo Carvalho de Melo [this message]
2017-11-18 8:29 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-11-09 14:55 ` [PATCH v1 4/5] perf, tools: Add fallback in perf_evsel__nr_cpus for no map Andi Kleen
2017-11-13 9:22 ` Jiri Olsa
2017-11-14 5:03 ` Andi Kleen
2017-11-09 14:55 ` [PATCH v1 5/5] perf, tools, script: Allow computing metrics in perf script Andi Kleen
2017-11-13 9:30 ` Jiri Olsa
2017-11-13 18:23 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171113182346.GC4123@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox