From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754467AbdKMSbG (ORCPT ); Mon, 13 Nov 2017 13:31:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:53986 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754439AbdKMSa7 (ORCPT ); Mon, 13 Nov 2017 13:30:59 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1953B21912 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Mon, 13 Nov 2017 15:30:57 -0300 From: Arnaldo Carvalho de Melo To: Wang Nan Cc: linux-kernel@vger.kernel.org, kan.liang@intel.com, jolsa@redhat.com, namhyung@kernel.org Subject: Re: [PATCH 2/7] perf tests: Set evlist of test__backward_ring_buffer() to !overwrite Message-ID: <20171113183057.GB8836@kernel.org> References: <20171113013809.212417-1-wangnan0@huawei.com> <20171113013809.212417-3-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171113013809.212417-3-wangnan0@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Nov 13, 2017 at 01:38:04AM +0000, Wang Nan escreveu: > Setting overwrite in perf_evlist__mmap() is meaningless because the > event in this evlist is already have 'overwrite' postfix and goes to > backward ring buffer automatically. Pass 'false' to perf_evlist__mmap() > to make it similar to others. applied > Signed-off-by: Wang Nan > --- > tools/perf/tests/backward-ring-buffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/tests/backward-ring-buffer.c b/tools/perf/tests/backward-ring-buffer.c > index d233ad3..992c917 100644 > --- a/tools/perf/tests/backward-ring-buffer.c > +++ b/tools/perf/tests/backward-ring-buffer.c > @@ -58,7 +58,7 @@ static int do_test(struct perf_evlist *evlist, int mmap_pages, > int err; > char sbuf[STRERR_BUFSIZE]; > > - err = perf_evlist__mmap(evlist, mmap_pages, true); > + err = perf_evlist__mmap(evlist, mmap_pages, false); > if (err < 0) { > pr_debug("perf_evlist__mmap: %s\n", > str_error_r(errno, sbuf, sizeof(sbuf))); > -- > 2.10.1