From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754371AbdKMSpl (ORCPT ); Mon, 13 Nov 2017 13:45:41 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:36156 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753233AbdKMSpj (ORCPT ); Mon, 13 Nov 2017 13:45:39 -0500 Date: Mon, 13 Nov 2017 18:45:01 +0000 From: Roman Gushchin To: Mike Kravetz CC: Dave Hansen , , Andrew Morton , Michal Hocko , Johannes Weiner , "Aneesh Kumar K.V" , Andrea Arcangeli , , Subject: Re: [PATCH] mm: show stats for non-default hugepage sizes in /proc/meminfo Message-ID: <20171113184454.GA18531@castle> References: <20171113160302.14409-1-guro@fb.com> <8aa63aee-cbbb-7516-30cf-15fcf925060b@intel.com> <20171113181105.GA27034@castle> <2579a26d-81d1-732e-ef57-33bb4c293cd6@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <2579a26d-81d1-732e-ef57-33bb4c293cd6@oracle.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [2620:10d:c092:200::1:eaba] X-ClientProxiedBy: HE1PR05CA0231.eurprd05.prod.outlook.com (2603:10a6:3:fa::31) To SN2PR15MB1086.namprd15.prod.outlook.com (2603:10b6:804:22::8) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2e9644ca-8464-4898-2523-08d52ac6b02f X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:SN2PR15MB1086; X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB1086;3:vL7DGrkmFoOzri8lp7q2JvveVccAG1VA07kEIs8K/Kvwgy6iRIcMBrvTFE4Cai7Emp7Q2pADA6RpysiT2fQ562hTTiQBCRXQuDi0CnVz2p/GoRzSNyGMsBquunyqCzl58HhN0v9l7WjZXMk3O5bXkgn7Aei59ITW8KGtBKn1cZxyMFns0FOBlGJv/7rHedZgWtbsE/Ejl8ctD0dYgfp3I7BAa3YcK7UYJOdbvprj6kZiLb4j3+IhxzHrZFnnIDIm;25:Y87fvW4GrinJVkjXa2B8a4IPyWknLyiKplFu+GNv3ZlobwdC2WsWl6KoUfVafcWHWiss0A4WMQ5E+r+dPeHlJGImOaEFf31PxGF9ywwGo9QAAWb7C+8/06gMkFg6djAd6adylhn6q5Y46yX53vIYlYvsfVai35U7dHKVd2+Dl58KD95ZW3Mxz+j0LTPKMGgcNKh4KtfEvSSl6rN3Imo7cxshHxtEIS541MG3zkFhQc1dheWzTaT08SzRLRkQ7gjZjvsL43mc8f16S3/tRdvPESmTprP3ylK6qs5M9XRL0dc0iFONbaxuNrbEnODu1zGJWy80IRL9e4RSJPT5jp3A9w==;31:0L7B8qumjj4gA9Zc5NrxDNCSqICof2svEZDjcJMqxIg0cLpo89MW0ZdT+IYRNPwSOzinlZuYekWVc8FVPajz4a3+IdoVUV634CluE+xlOmrRIVy2F3os0YoAxZY7f1eftK7qLzc7mcjfyIY9TBwzBLZSEyVmPBFLn5G489ZNRiVOti81V0SM0yn00xkeD5sxHDTvtJ5JDkAznI6s0vCb+7I8X8PGySFnNdtj3+QWhtc= X-MS-TrafficTypeDiagnostic: SN2PR15MB1086: X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB1086;20:MA5bxvaYhp0PIE7QcdtWEHb3PROQ6gZ8FlHsDtYP72yGOhDRe09hsJQX33OM8NwyYoeyrLLgZ5FLHeMAnnn+HDKhyof8lJZJTrPNNGTAscD6qQwPlQn1Y20uE4elVkTuLWBUFH9FrguHct5ZvdnT27KSlYIXhC67qY7+r12q/UkBbOV6cahNT/U0hv3oll7qQ9Ut7jb+XnjOKWekUQSPs20uWjHrJc7ZbVSa1SNsECjbrpB+T8Jgkcg+m+9Ovmy3yNjVI23Dni1KJyzZ+U3JdcU+kLfwiYDj8fizAFIwZpDHOm7zModszOtgeOT8EzdIrXoaPA8F8lIwxrGuguRUn4gwHeuEgWxW69bMUuHV9DUyzzhcGZGNV2HoPwvVDDnH2JHOQyszLzrtSNU5j85dWhFwCecoIaFfqa8R2YFhEdEyXLYnY8/lXwSRJ7GLmXBtsUjceMy2cp6km0nnza/tWfv1+eDl74G4J5OW8ePbdb+UwDhVKVzQZPNCnTbwAMnQ;4:AJ7wRqbI7T/LYLFdY/kyixehQ5/8ioOwijGl0dacztyvsXHUqhLF3sefc6lrrkAC/8+Pu8Th+pp2p9oEmwkqgvYfZGaa/P83WkhaL1yDkF21jIg3FYN0PzOCqzdIxPSj3U4eE+zhV/s7gQcBHNhuhckTuDH+oWHHT5maAzZIWsvzFZyV8jQ0fDIOkXIJAP+SYZ1xjINu2d6YdLkD8LYgFMvBltyAfkSShY3aVQSnfsf2LHeem+IomBaeVgPRwmz3wUzwd2QwaYJoeZm6iqKJew== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(11241501159)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3231022)(3002001)(10201501046)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(20161123555025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:SN2PR15MB1086;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:SN2PR15MB1086; X-Forefront-PRVS: 0490BBA1F0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(979002)(6009001)(376002)(346002)(199003)(189002)(24454002)(105586002)(106356001)(54906003)(93886005)(8936002)(6246003)(53936002)(6496005)(9686003)(25786009)(4326008)(97736004)(16586007)(58126008)(316002)(478600001)(53546010)(86362001)(5660300001)(47776003)(8676002)(7736002)(83506002)(33716001)(23726003)(305945005)(229853002)(101416001)(76176999)(1076002)(6116002)(2906002)(81166006)(81156014)(54356999)(33656002)(50986999)(6916009)(68736007)(2950100002)(50466002)(6666003)(189998001)(55016002)(18370500001)(42262002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:SN2PR15MB1086;H:castle;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN2PR15MB1086;23:7CjR0IF1CH1xkSvwr+pQivOlTj2ZEsuY0Wxxb6g8j?= =?us-ascii?Q?nzalWxCK3/Kr6OUceGgwr0HURT2BzeNRmjBpbZd66vyY+4ITkAlgtoD+Zavj?= =?us-ascii?Q?O5M3ZjYnKzYDAUNdfDsybNK+Y22E7W8FGLrez5nBaTBzCv1m3Dl6VflDHEhU?= =?us-ascii?Q?OwdlbjpqEI+6fEfM3vcCxu5uIdxk9NZv1sc9ciqVFd8y2Kzu9M2CsHnK6SVr?= =?us-ascii?Q?b0Bf15VpHQyPgCmKIOd6x54jRPLI1IhbCrX8Z5HrD70zP3TvOT9amURICG3x?= =?us-ascii?Q?WBYXrfdzdOyaqOig7BcvFZ4q5c7antjSv7v93kpzUX69/ZNIGeZJqFZ8NSmv?= =?us-ascii?Q?rKXBFRMZFdFPwCHzppS6X+Ou7FUsCeMr8yQHHnXDGpWLZmjq4muIqbDM1qi6?= =?us-ascii?Q?ydywkSyYvzSXD7+Xqls8J7o+bFw2Epzk1u4CTlrZpadePRSGFEh1WJmLlg03?= =?us-ascii?Q?3nF1fC1PQi8DV8GbrMh+3afwXzM31sF+O4pfekf7/wx/Rk6x/adYFRgvK3Wa?= =?us-ascii?Q?BIxTkDSKLKl7qYxZkaTCXAz8ZeAND2jRGsNtG/4UsOGFsmcdLLqSwQVtx1pu?= =?us-ascii?Q?0fVtslZSupXPZae753Jhe8rHAwspVEZQZIfm8xc+AmLzCzaYDe3cjVY0oRsc?= =?us-ascii?Q?gEqjROf2BtWo68m75AKr8eu5V6msC3l0oNQsBxDWCDkVd39VbpFrYTXiraWF?= =?us-ascii?Q?cAm+8KjECLJz1Mgs/k61CgerRLDYkFF7k/U+nuSLSdtLH49aEDabpGCZSUUt?= =?us-ascii?Q?VEYjT+vbHDd5kbU38fwonlVWmwDqLZkG/OqjB+0+fJ2nUAdAXzPRcHdcHxbW?= =?us-ascii?Q?y3x9kb58hccw1S1X3nrGcEJBLF+n/GKfKq8kvmWVOBGAyM0OxHqVrn9T2IkF?= =?us-ascii?Q?YOT6DKhAG17/LdR+LbunWWZhgLw973m90Og3Enr53aFofC6RpAyCZlU/t1Mk?= =?us-ascii?Q?jbzoMbrOraKWrxKhyPISa0nAjzwAL6Uv0bKoG/FQ+cqr7Q3QSo5lVZ6gxjmk?= =?us-ascii?Q?hmh+VHyhfM8x+tvVy4tXmBAjmP2EnVjJFOfOdh3ubyYDCt+XQIKRyI4mZWdX?= =?us-ascii?Q?JVxQtmrB6NErzdY7WakfE9RUdJCjZSLHOt2fFBAdL6KeQLhO/OzTr+Mh/Z5y?= =?us-ascii?Q?JYPrSuC6iFnSQmRyhhvjbWK2hR8vTO7rum8m2K0Xsj0vu03Xzpnm+CTeJnZ/?= =?us-ascii?Q?6GCJQozJxn/Yu7pGqrEs8diAh2aUduKRLPL6cXEnA5kGGle3GIhJX70Uk/fQ?= =?us-ascii?Q?CAfWymkBNbG+kNA8hC31+McX1r+vf+L9Qyrw75mF8+uWxPDS+Yvg2JHVv8cK?= =?us-ascii?Q?0C8utCdCfIVoyDK8z9INHE=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB1086;6:vOdM0dvZ+SKGAYhdaVVdx5XQ+3DvOF9JwNRfKJGRgY6MlvlghL3NwUzc92dmDljDqcANX78fTM65/W2aS9A1JTeDCYgaZRp3fx4qgOIIEEGqfq0aDwkXrYxhvoViYlcLd1nf9iTYNxJP4/j3gKYZDxtF7SgrjwmJjUG2NUlS41VhGarPfwcHa33B+/16XE5Zz1TItJm6hw2bP9yBy02gWlAJHB7cUuRKuXGjlOH3UUgQmQO61dnETEbgdq5ll5RFWI5ONTtDlQ1yjaZRScXu00yV+EErqCVSwbHDkWmDnGhLX3VrYDIgfmIKTaLFCvB8UfFHGr8swM4b+P0znnB8zJSYNGEpzkK7+AAI8nlHqWQ=;5:1xAdACc3DVAVeHVuO9u6jdG8gRCNsAoQ/MkbpvWJozUm5Z6r9A/R3vDCN4Q04i3U6WuJG1tLt2t2FWxOkSYcWS3jtHyS5D7Zm4S08AyYbrVdPNkwqKlOoGJ9mm9n2LTjMIfGW6klQ+ZSsP6o00cVtgvJVtzZTOIAomD0OvpIXW0=;24:tg7PTpa7E2eqebl5ltTumWBJAoUv/O186+XqEJqYwBjPmJKZnsgRlp1+XskdkBKyTr75lTRsa7DaLxtEBNiX4gQLmh09PbFBiyVgCxZhabU=;7:LDlT5MbOE8RX5D6g1pB1fmpC5ZzPbJ1ItRCNblZLToWmqzwqlzegBPoGHzgBgw9OHv5x14k2zkY5VHTXHStYT6eRQjsjcCMNvRf+pbTCFTolnkkPYEG4phcNBaQ2k9T3znsbqMuxl43Xo2xbplz6eaOewxAFYQUpPlBqG2SU/eCcRGQ3NxnVDlT1KvfDWlfOU9XMnVMpGLA9/bRM5IDjcH3Odt617vFJL/iWbo2B1tPQot8t+QvwV5yDTII0xJHI SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB1086;20:nd23ITTPk2XDCSXloRBvgkNnRwac3W2L0359WSh5rN/aSF+0Jlm9pmIy4HyXvVjN8WgNejPp/qv2YVvkVxzvqj9SSJngMQWHmW9B7nm9/4GEWE4/Wkmg37vUvsbYDjEfqjApa0qiEWIbZ51Db3icGa7wWXldrcy3+TJoOa3PYJM= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Nov 2017 18:45:16.6344 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2e9644ca-8464-4898-2523-08d52ac6b02f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR15MB1086 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-13_10:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 13, 2017 at 10:30:10AM -0800, Mike Kravetz wrote: > On 11/13/2017 10:17 AM, Dave Hansen wrote: > > On 11/13/2017 10:11 AM, Roman Gushchin wrote: > >> On Mon, Nov 13, 2017 at 09:06:32AM -0800, Dave Hansen wrote: > >>> On 11/13/2017 08:03 AM, Roman Gushchin wrote: > >>>> To solve this problem, let's display stats for all hugepage sizes. > >>>> To provide the backward compatibility let's save the existing format > >>>> for the default size, and add a prefix (e.g. 1G_) for non-default sizes. > >>> > >>> Is there something keeping you from using the sysfs version of this > >>> information? > >> > >> Just answered the same question to Michal. > >> > >> In two words: it would be nice to have a high-level overview of > >> memory usage in the system in /proc/meminfo. > > > > I don't think it's worth cluttering up meminfo for this, imnho. > > I tend to agree that it would be better not to add additional huge page > sizes here. It may not seem too intrusive to (potentially) add one extra > set of entries for GB huge pages on x86. However, other architectures > such as powerpc or sparc have several several huge pages sizes that could > potentially be added here as well. Although, in practice one does tend > to use a single huge pages size. If you change the default huge page > size, then those entries will be in /proc/meminfo. I do agree that it might add some unnecessary verbosity if these sizes are not used, but if they are, this information is super-useful. So, might be a conditional printing will work here? Or, at least, some total counter, e.g. how much memory is consumed by hugetlb pages? Thanks!