From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752798AbdKNB5S (ORCPT ); Mon, 13 Nov 2017 20:57:18 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:52582 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751438AbdKNB5B (ORCPT ); Mon, 13 Nov 2017 20:57:01 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 17FD76081B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Mon, 13 Nov 2017 17:56:59 -0800 From: Stephen Boyd To: Colin King Cc: Michael Turquette , linux-clk@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: cdce925: remove redundant check for non-null parent_name Message-ID: <20171114015659.GB11955@codeaurora.org> References: <20170905150348.20041-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170905150348.20041-1-colin.king@canonical.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/05, Colin King wrote: > From: Colin Ian King > > The check for a non-null parent_name is always true as there is an > earlier check for a null parent_name that returns -ENODEV. Remove this > redundant check and always set init.num_parents to 1. > > Detected by CoverityScan CID#1309477 ("Logically dead code") > > Signed-off-by: Colin Ian King > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project