From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754750AbdKNQfM (ORCPT ); Tue, 14 Nov 2017 11:35:12 -0500 Received: from mail-pf0-f171.google.com ([209.85.192.171]:49986 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752360AbdKNQfB (ORCPT ); Tue, 14 Nov 2017 11:35:01 -0500 X-Google-Smtp-Source: AGs4zMY2I5ym18GMGQqy/8SDVYGZlHOAXB+KZMqHbXNz3+8vntGv+h/liSB7Ehqu/OQjfmVrCWi9yA== Date: Tue, 14 Nov 2017 08:34:57 -0800 From: Stephen Hemminger To: Vitaly Kuznetsov Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Mohammed Gamal Subject: Re: [PATCH net] hv_netvsc: preserve hw_features on mtu/channels/ringparam changes Message-ID: <20171114083457.5ec8c4f0@xeon-e3> In-Reply-To: <20171114152205.10943-1-vkuznets@redhat.com> References: <20171114152205.10943-1-vkuznets@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Nov 2017 16:22:05 +0100 Vitaly Kuznetsov wrote: Yes, this looks like a real issue. > + /* Query hardware capabilities if we're called from netvsc_probe() */ > + if (!net->hw_features) { > + ret = rndis_netdev_set_hwcaps(net_device, rndis_device); > + if (ret != 0) > + goto err_dev_remv; > + } > + Rather than conditional behavior in rndis_filter_device_add, it would be cleaner to make the call to get hardware capabilities there. Please respin and make the query of host a separate function.