From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754283AbdKNSLw (ORCPT ); Tue, 14 Nov 2017 13:11:52 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:50761 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753018AbdKNSLn (ORCPT ); Tue, 14 Nov 2017 13:11:43 -0500 X-Google-Smtp-Source: AGs4zMY5ek2vUSrFsIHAfzHPZ8cUjKUx7zE4drUQ87CkxpZv2FpOrXzRmeoTwyrsBfigZWrx9YUuGA== Date: Tue, 14 Nov 2017 10:11:29 -0800 From: Stephen Hemminger To: Kirill Tkhai Cc: davem@davemloft.net, vyasevic@redhat.com, kstewart@linuxfoundation.org, pombredanne@nexb.com, vyasevich@gmail.com, mark.rutland@arm.com, gregkh@linuxfoundation.org, adobriyan@gmail.com, fw@strlen.de, nicolas.dichtel@6wind.com, xiyou.wangcong@gmail.com, roman.kapl@sysgo.com, paul@paul-moore.com, dsahern@gmail.com, daniel@iogearbox.net, lucien.xin@gmail.com, mschiffer@universe-factory.net, rshearma@brocade.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, ebiederm@xmission.com, avagin@virtuozzo.com, gorcunov@virtuozzo.com Subject: Re: [PATCH] net: Convert net_mutex into rw_semaphore and down read it on net->init/->exit Message-ID: <20171114101129.351d8aed@xeon-e3> In-Reply-To: <151066759055.14465.9783879083192000862.stgit@localhost.localdomain> References: <151066759055.14465.9783879083192000862.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Nov 2017 16:53:33 +0300 Kirill Tkhai wrote: > + /* > + * RCU-protected list, modifiable by pernet-init and -exit methods. > + * When net namespace is alive (net::count > 0), all the changes > + * are made under rw_sem held on write. > + */ > + struct list_head fib_notifier_ops; > If you use __rcu annotation then it could be checked (and the comment is not needed).