From: Ralf Baechle <ralf@linux-mips.org>
To: jiaxun.yang@flygoat.com
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] MIPS: Loongson64: Yeeloong add platform driver Yeeloong is a laptop with a MIPS Loongson 2F processor, AMD CS5536 chipset, and KB3310B controller.
Date: Tue, 14 Nov 2017 14:35:24 +0100 [thread overview]
Message-ID: <20171114133524.GE13046@linux-mips.org> (raw)
In-Reply-To: <20171112063617.26546-3-jiaxun.yang@flygoat.com>
On Sun, Nov 12, 2017 at 02:36:16PM +0800, jiaxun.yang@flygoat.com wrote:
> + asm(".set noreorder\n");
> + /* input enable */
> + outl(0x00000800, (gpio_base | 0xA0));
> + /* revert the input */
> + outl(0x00000800, (gpio_base | 0xA4));
> + /* event-int enable */
> + outl(0x00000800, (gpio_base | 0xB8));
> + asm(".set reorder\n");
I forgot to comment on this .set noreorder thing. GCC expects gas to be
in reorder mode at the end of every bit of inline assembler, so above
code is at the mercy of GCC.
Not sure what the intent was here, was it to avoid GCC from reordering
the outl() calls? These are already marked volatlile and should not be
reordered by GCC. .set (no)reorder on the other hand is a directive
to GAS and GCC won't be influenced at all by it.
Cheers,
Ralf
next prev parent reply other threads:[~2017-11-14 13:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-12 6:36 [PATCH 1/4] MIPS: Lonngson64: Copy kernel command line from arcs_cmdline Since lemte-2f/marchtype.c need to get cmdline from loongson.h this patch simply copy kernel command line from arcs_cmdline to fix that issue jiaxun.yang
2017-11-12 6:36 ` [PATCH 2/4] MIPS: Loongson64: lemote-2f move ec_kb3310b.h to include dir and clean up To operate EC from platform driver, this head file need able to be include from anywhere. This patch just move ec_kb3310b.h to include dir and clean up ec_kb3310b.h jiaxun.yang
2017-11-13 14:27 ` Ralf Baechle
2017-11-12 6:36 ` [PATCH 3/4] MIPS: Loongson64: Yeeloong add platform driver Yeeloong is a laptop with a MIPS Loongson 2F processor, AMD CS5536 chipset, and KB3310B controller jiaxun.yang
2017-11-14 13:21 ` Ralf Baechle
2017-11-14 13:35 ` Ralf Baechle [this message]
2017-11-12 6:36 ` [PATCH 4/4] MIPS: Loongson64: Load platform device during boot This patch just add pdev during boot to load the platform driver jiaxun.yang
2017-11-14 13:29 ` Ralf Baechle
2017-11-13 14:21 ` [PATCH 1/4] MIPS: Lonngson64: Copy kernel command line from arcs_cmdline Since lemte-2f/marchtype.c need to get cmdline from loongson.h this patch simply copy kernel command line from arcs_cmdline to fix that issue Ralf Baechle
2017-11-15 3:11 ` [PATCH v3 1/4] MIPS: Lonngson64: Copy kernel command line from arcs_cmdline Jiaxun Yang
2017-11-15 3:11 ` [PATCH v3 2/4] MIPS: Loongson64: lemote-2f move ec_kb3310b.h to include dir and clean up Jiaxun Yang
2017-11-15 3:11 ` [PATCH v3 3/4] MIPS: Loongson64: Yeeloong add platform driver Jiaxun Yang
2017-11-15 3:11 ` [PATCH v3 4/4] MIPS: Loongson64: Load platform device during boot Jiaxun Yang
2017-11-16 4:22 ` [PATCH v3 1/4] MIPS: Lonngson64: Copy kernel command line from arcs_cmdline Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171114133524.GE13046@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox